Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding frontmatter; cherry-picking commit into 0.3 #943

Merged
merged 2 commits into from
Feb 27, 2019
Merged

adding frontmatter; cherry-picking commit into 0.3 #943

merged 2 commits into from
Feb 27, 2019

Conversation

samodell
Copy link
Contributor

No description provided.

bvennam and others added 2 commits February 27, 2019 10:19
@bvennam @samodell
Deploy using private registry (knative#847)
8e6a733 
* new doc for deploying with private registry

* update last few steps

* header sizes

* capitalization

* updating with correct registry annotation and small edits

* wording

* formatting

* formatting

* Update serving/deploying-with-private-registry.md

Co-Authored-By: beemarie <[email protected]>

* Update serving/deploying-with-private-registry.md

Co-Authored-By: beemarie <[email protected]>

* Update serving/deploying-with-private-registry.md

Co-Authored-By: beemarie <[email protected]>

* Update serving/deploying-with-private-registry.md

Co-Authored-By: beemarie <[email protected]>

* Update serving/deploying-with-private-registry.md

Co-Authored-By: beemarie <[email protected]>

* update based on feedback

* missing <

* adding tic marks for filename

* udpate with helloworld-go sample

* add testing application

* update return from helloworld app

* update readme with link to doc

* Update serving/deploying-with-private-registry.md

Co-Authored-By: beemarie <[email protected]>

* Update serving/deploying-with-private-registry.md

Co-Authored-By: beemarie <[email protected]>

* Update serving/deploying-with-private-registry.md

Co-Authored-By: beemarie <[email protected]>

* Update serving/deploying-with-private-registry.md

Co-Authored-By: beemarie <[email protected]>

* Update serving/deploying-with-private-registry.md

Co-Authored-By: beemarie <[email protected]>
@samodell
adding frontmatter; cherry-picking commit into 0.3
f4cd342
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no Indicates the PR's author has not signed the CLA. label Feb 27, 2019
@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 27, 2019
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: samodell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@samodell
Copy link
Contributor Author

@beemarie Can you comment here saying you approve merging your guide into the release-0.3 branch? Thanks!

@bvennam
Copy link
Contributor

bvennam commented Feb 27, 2019

I approve my guide on "Deploying to Knative using a private container registry" being merged into the release-0.3 branch.

Sorry about that - this was my fault!

@samodell
Copy link
Contributor Author

Not your fault at all @beemarie -- we're having to do some odd stuff with the release-0.3 branch since that's where we're preparing the content for our eventual move to the website. Thanks!

@samodell samodell added cla: yes Indicates the PR's author has signed the CLA. and removed cla: no Indicates the PR's author has not signed the CLA. labels Feb 27, 2019
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@RichieEscarez RichieEscarez added the lgtm Indicates that a PR is ready to be merged. label Feb 27, 2019
@knative-prow-robot knative-prow-robot merged commit 86b783b into knative:release-0.3 Feb 27, 2019
@samodell samodell mentioned this pull request Feb 27, 2019
Closed
2 tasks
RichieEscarez pushed a commit to RichieEscarez/docs that referenced this pull request Mar 19, 2019
@samodell @RichieEscarez
adding frontmatter; cherry-picking commit into 0.3 (knative#943)
962154a 
* Deploy using private registry (knative#847)

* new doc for deploying with private registry

* update last few steps

* header sizes

* capitalization

* updating with correct registry annotation and small edits

* wording

* formatting

* formatting

* Update serving/deploying-with-private-registry.md

Co-Authored-By: beemarie <[email protected]>

* Update serving/deploying-with-private-registry.md

Co-Authored-By: beemarie <[email protected]>

* Update serving/deploying-with-private-registry.md

Co-Authored-By: beemarie <[email protected]>

* Update serving/deploying-with-private-registry.md

Co-Authored-By: beemarie <[email protected]>

* Update serving/deploying-with-private-registry.md

Co-Authored-By: beemarie <[email protected]>

* update based on feedback

* missing <

* adding tic marks for filename

* udpate with helloworld-go sample

* add testing application

* update return from helloworld app

* update readme with link to doc

* Update serving/deploying-with-private-registry.md

Co-Authored-By: beemarie <[email protected]>

* Update serving/deploying-with-private-registry.md

Co-Authored-By: beemarie <[email protected]>

* Update serving/deploying-with-private-registry.md

Co-Authored-By: beemarie <[email protected]>

* Update serving/deploying-with-private-registry.md

Co-Authored-By: beemarie <[email protected]>

* Update serving/deploying-with-private-registry.md

Co-Authored-By: beemarie <[email protected]>

* adding frontmatter; cherry-picking commit into 0.3
knative-prow-robot pushed a commit that referenced this pull request Mar 20, 2019
@RichieEscarez @knative-prow-robot
Merge website files into Master (#1025)
3c04f86 
* Add front matter to Build files (#833)

* Update README.md

* Adding front matter to builds.md

* Update installing-build-component.md

* Update README.md

Revert changes so Richie can handle this with the index file

* Update builder-contract.md

* Update personas.md

* Update auth.md

* Update creating-builds.md

* Update build-templates.md

* sentence case

* sentence case

* sentence case

* Adding frontmatter to /install/ (#834)

* Adds front matter to Serving (#838)

* Update accessing-logs.md

* Update accessing-metrics.md

* Update accessing-traces.md

* Update cluster-local-route.md

* Update debugging-application-issues.md

* Update debugging-performance-issues.md

* Update gke-assigning-static-ip-address.md

* Update installing-logging-metrics-traces.md

* Update outbound-network-access.md

* Update setting-up-a-logging-plugin.md

* Update using-a-custom-domain.md

* Update using-an-ssl-cert.md

* Update using-cert-manager-on-gcp.md

* Update using-external-dns-on-gcp.md

* site index for fluentd folder (#839)

* add Hugo index files and frontmatter (#840)

* hugo build files for autogen refdocs (#841)

* move resources and readme (#843)

* site: add blog (#837)

* add blog folder

* switch to sentence case

* site: add community and contributing (#836)

* add _index.md files and front matter

* switch to sentance case caps

* fix weights

* Update community/samples/README.md

Co-Authored-By: RichieEscarez <[email protected]>

* site: restructure content into a "docs" directory (#842)

* move content into a 'docs' directory

* inject additional 'docs' directory

* site: add build files and front matter to serving samples (#850)

* new _index.md files and front matter

* serving samples + fix urls

* remove file

* add PR#851 - channels (#853)

* Update README.md (#854)

* Remove README.md from all links (#855)

* Remove README.md from all links

* mend

* mend

* mend

* Update _index.md

* Update _index.md

* Update _index.md

* Update _index.md

* fix links in community (#857)

* Update _index.md (#856)

* Update _index.md

* Update _index.md

* Update _index.md

* Update _index.md

* Update _index.md

* Update _index.md

* Update _index.md

* Update _index.md

* Update _index.md

* Update _index.md

* Update _index.md

* Update _index.md

* Update _index.md

* Update _index.md

Adds missing pointer to README

* Update _index.md

* Update _index.md

* Update _index.md

* Update _index.md

* Update _index.md

* Update _index.md

* Update _index.md

* Update _index.md

* Update _index.md

* Update _index.md

* Update _index.md

* Update _index.md

* Update _index.md

* Update _index.md

* Update _index.md

* Update _index.md

* Update _index.md

* Update _index.md

* Update _index.md

* Update _index.md

* revert

* fix build links (#858)

* site: fix eventing links (#859)

* fix eventing links

* Update README.md

* fix install links (#860)

* site: fix serving links (#861)

* fix serving links

* Update using-external-dns-on-gcp.md

* remove hardcoded github link (#863)

* Update README.md (#864)

Fix links by removing md file extensions.

* Fix links (#866)

* Fix links

* Update installing-build-component.md

* Update builder-contract.md

* add missing hello-world directory (#865)

* Link fixes for Build (#867)

* Fix links

* Update installing-build-component.md

* Update builder-contract.md

* Update creating-builds.md

* Update builder-contract.md

* Update builds.md

* Update creating-builds.md

* Update installing-build-component.md

* Update installing-build-component.md

* Update creating-builds.md

* Update creating-builds.md

* Update builds.md

* Update build-templates.md

* convert to Hugo rel link

* Manually run prettier.io (#880)

* Manually run prettier.io

Trying to fix the stuff that hits prettier.io bugs.

* Fix prettier.io issues.

* Revert manual link fixes (use new build script instead) (#927)

* Revert "convert to Hugo rel link"

This reverts commit f1bbc8e.

* Revert "Fix links (#866)"

This reverts commit 3a57ffe.

* Revert "remove hardcoded github link (#863)"

This reverts commit fb7fdd9.

* Revert "site: fix serving links (#861)"

This reverts commit f61514c.

* Revert "fix install links (#860)"

This reverts commit 1fcf32b.

* Revert "site: fix eventing links (#859)"

This reverts commit 8809165.

* Revert "fix build links (#858)"

This reverts commit 847e08b.

* Revert "fix links in community (#857)"

This reverts commit 0cd5a44.

* Revert "Remove README.md from all links (#855)"

This reverts commit 2029c8b.

* Revert "Update README.md (#864)"

This reverts commit 072c731.

* Adding frontmatter to Gloo guide (#939)

*  adding frontmatter; cherry-picking commit into 0.3 (#943)

* Deploy using private registry (#847)

* new doc for deploying with private registry

* update last few steps

* header sizes

* capitalization

* updating with correct registry annotation and small edits

* wording

* formatting

* formatting

* Update serving/deploying-with-private-registry.md

Co-Authored-By: beemarie <[email protected]>

* Update serving/deploying-with-private-registry.md

Co-Authored-By: beemarie <[email protected]>

* Update serving/deploying-with-private-registry.md

Co-Authored-By: beemarie <[email protected]>

* Update serving/deploying-with-private-registry.md

Co-Authored-By: beemarie <[email protected]>

* Update serving/deploying-with-private-registry.md

Co-Authored-By: beemarie <[email protected]>

* update based on feedback

* missing <

* adding tic marks for filename

* udpate with helloworld-go sample

* add testing application

* update return from helloworld app

* update readme with link to doc

* Update serving/deploying-with-private-registry.md

Co-Authored-By: beemarie <[email protected]>

* Update serving/deploying-with-private-registry.md

Co-Authored-By: beemarie <[email protected]>

* Update serving/deploying-with-private-registry.md

Co-Authored-By: beemarie <[email protected]>

* Update serving/deploying-with-private-registry.md

Co-Authored-By: beemarie <[email protected]>

* Update serving/deploying-with-private-registry.md

Co-Authored-By: beemarie <[email protected]>

* adding frontmatter; cherry-picking commit into 0.3

* Update Knative-with-Minishift.md (#988)

Update to correct title (Openshift > Minishift), as mentioned by Ashleigh in the Docs WG.

* add type:docs + enable relative links (#990)

* Deleting an unnecessary file

accidentally copied in extra file

* update ref docs api build script and files (#997)

* all links must have ./ (#1004)

* all links must have ./

* Update contributing/README.md

Co-Authored-By: RichieEscarez <[email protected]>

* Update contributing/README.md

Co-Authored-By: RichieEscarez <[email protected]>

* Update for clarity

* Update README.md

Fixing my poorly formatting suggestion

* ref tool steps + script (#1008)

* Incorporate edits from #1008 (#1010)

* Incorporate edits from #1008

* Add "contributor" info link

* page-by-page link check fixes (#1024)

* update readmes - source and site versions

* rename file to fix left nav

* rename file and remove folder to fix left nav
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RichieEscarez RichieEscarez Awaiting requested review from RichieEscarez

@carieshmarie carieshmarie Awaiting requested review from carieshmarie

Assignees
No one assigned
Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@samodell @googlebot @knative-prow-robot @bvennam @RichieEscarez