Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color of the hover label fixed #497

Merged
merged 1 commit into from
Apr 1, 2022
Merged

Conversation

tomasstrba
Copy link
Contributor

Task/Issue URL: https://app.asana.com/0/1199178362774117/1202055431868952/f
Tech Design URL:
CC: @jaceklyp

Description:
Fix of the hover label font color in dark mode. (Hover label is the label in the bottom left corner shown when cursor is over the link)

Steps to test this PR:

  1. Switch to dark mode in system.
  2. Verify the hover label font color is correct (link is readable)
  3. Switch to light mode in system
  4. Verify the hover label font color is correct (link is readable)
  5. Switch to dark mode in the app Preferences
  6. Verify the hover label font color is correct (link is readable)2.

Internal references:

Software Engineering Expectations
Technical Design Template
When ready for review, remember to post the PR in MM

@mallexxx mallexxx self-assigned this Apr 1, 2022
Copy link
Collaborator

@mallexxx mallexxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mallexxx mallexxx assigned tomasstrba and unassigned mallexxx Apr 1, 2022
@tomasstrba
Copy link
Contributor Author

Thanks Alex

@tomasstrba tomasstrba merged commit 21f2a8b into develop Apr 1, 2022
@tomasstrba tomasstrba deleted the tom/hover-label-color branch April 1, 2022 12:37
samsymons added a commit that referenced this pull request Apr 4, 2022
# By Tomas Strba (5) and others
# Via GitHub
* develop:
  Refresh the Autofill panel after importing (#496)
  Require authentication for login export (#494)
  Observations database clearing improvements (#495)
  Fix handling external schemes in address bar (#493)
  New autoconsent rules and move tab cleanup out of onCommitted (#489)
  Safari CSV Passwords import +LastPass, 1Password (#483)
  Split preferences into multiple screens and add an option to show full URL (#487)
  Color of hover label fixed (#497)
  Add AMP links protection (#488)
  Enhancements of fire button options (#484)
  Rename Logins+ to Autofill (#492)
  new tab page low hanging fruit (#491)
  Fix threading issues in Autoconsent (#478)
  Navigation bar improvement: CMD + back or CMD + forward opens a new tab (#486)
  TextField refactored to TextView in order to make it scrollable (#481)
  More Xcode cleaning (#485)

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants