Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh the Autofill panel after importing #496

Merged
merged 5 commits into from
Apr 4, 2022

Conversation

samsymons
Copy link
Collaborator

Task/Issue URL: https://app.asana.com/0/1199230911884351/1202060497997056/f
Tech Design URL:
CC:

Description:

This PR refreshes the Autofill panel after importing data.

Steps to test this PR:

  1. Clear out all of your Autofill data using the Debug menu -> Reset Secure Vault Data
  2. Open the Logins+/Autofill panel and use the empty state Import button to import data
  3. Verify that the panel shows your data after importing

Testing checklist:

  • Test with Release configuration
  • Test proper deallocation of tabs
  • Make sure committed submodule changes are desired

Internal references:

Software Engineering Expectations
Technical Design Template
When ready for review, remember to post the PR in MM

@tomasstrba tomasstrba self-requested a review April 1, 2022 10:51
@tomasstrba tomasstrba self-assigned this Apr 1, 2022
Copy link
Contributor

@tomasstrba tomasstrba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍 💯

Probably not related to this PR. Does it make sense to not require authentication if the secure vault is empty?

@tomasstrba tomasstrba assigned samsymons and unassigned tomasstrba Apr 1, 2022
@samsymons
Copy link
Collaborator Author

@tomasstrba I think it does, yeah. I might try and sneak that in before merging if that's okay.

@samsymons
Copy link
Collaborator Author

Actually, I'm going to write this up as a separate task and work on it for the first release post-beta.

@samsymons samsymons merged commit d5d19f8 into develop Apr 4, 2022
@samsymons samsymons deleted the sam/logins-importing-fixes branch April 4, 2022 00:47
samsymons added a commit that referenced this pull request Apr 4, 2022
# By Tomas Strba (5) and others
# Via GitHub
* develop:
  Refresh the Autofill panel after importing (#496)
  Require authentication for login export (#494)
  Observations database clearing improvements (#495)
  Fix handling external schemes in address bar (#493)
  New autoconsent rules and move tab cleanup out of onCommitted (#489)
  Safari CSV Passwords import +LastPass, 1Password (#483)
  Split preferences into multiple screens and add an option to show full URL (#487)
  Color of hover label fixed (#497)
  Add AMP links protection (#488)
  Enhancements of fire button options (#484)
  Rename Logins+ to Autofill (#492)
  new tab page low hanging fruit (#491)
  Fix threading issues in Autoconsent (#478)
  Navigation bar improvement: CMD + back or CMD + forward opens a new tab (#486)
  TextField refactored to TextView in order to make it scrollable (#481)
  More Xcode cleaning (#485)

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants