Enhancements of fire button options #484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @tomasstrba :) I noticed a small UI glitch when displaying "All tabs open to selected sites will close" label:
The websites list is not resized correctly (probably doesn't take the "All tabs..." label into account) and websites are not visible. In this state, if you switch back to "All data" and then again "Current tab", the layout is fixed. |
|
good catch Dominik! 💯 the glitch should be fixed |
samsymons
added a commit
that referenced
this pull request
Apr 4, 2022
# By Tomas Strba (5) and others # Via GitHub * develop: Refresh the Autofill panel after importing (#496) Require authentication for login export (#494) Observations database clearing improvements (#495) Fix handling external schemes in address bar (#493) New autoconsent rules and move tab cleanup out of onCommitted (#489) Safari CSV Passwords import +LastPass, 1Password (#483) Split preferences into multiple screens and add an option to show full URL (#487) Color of hover label fixed (#497) Add AMP links protection (#488) Enhancements of fire button options (#484) Rename Logins+ to Autofill (#492) new tab page low hanging fruit (#491) Fix threading issues in Autoconsent (#478) Navigation bar improvement: CMD + back or CMD + forward opens a new tab (#486) TextField refactored to TextView in order to make it scrollable (#481) More Xcode cleaning (#485) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1177771139624306/1201744687581532/f
Tech Design URL: -
Description:
This PR contains some follow-up work related to fire button options. Please see macOS: quick bits from Fire Button option fixes for the complete list of behavioral and visual changes
Steps to test this PR:
Open one window with duckduckgo.com and second window with wikipedia.org.
Select the window with wikipedia.org, open fire button dialog, and select "Current Tab".
Make sure the warning "All tabs open to selected sites will close" is not visible.
Select duckduckgo.com window and add new tab with wikipedia.org
Open fire button dialog, and select "Current Tab".
Make sure the warning "All tabs open to selected sites will close" is visible.
Testing checklist:
Internal references:
Software Engineering Expectations
Technical Design Template
When ready for review, remember to post the PR in MM