Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More Xcode cleaning #485

Merged
merged 2 commits into from
Mar 30, 2022
Merged

More Xcode cleaning #485

merged 2 commits into from
Mar 30, 2022

Conversation

tomasstrba
Copy link
Contributor

Task/Issue URL: https://app.asana.com/0/1201037661562251/1199661670583310/f
https://app.asana.com/0/1199230911884351/1201928755345685/f

Description:
This PR contains:

  • Renaming of tooltip to tab preview in order to avoid confusion

  • Unification of file group names in Unit Tests folder

Steps to test this PR:

  1. Make sure tab previews work
  2. Make sure you can compile the product using all available compilation schemes

Testing checklist:

  • Make sure committed submodule changes are desired

Internal references:

Software Engineering Expectations
Technical Design Template
When ready for review, remember to post the PR in MM

@tomasstrba tomasstrba requested a review from ayoy March 28, 2022 12:53
Copy link
Collaborator

@ayoy ayoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! All works fine.

@ayoy ayoy assigned tomasstrba and unassigned ayoy Mar 30, 2022
@tomasstrba
Copy link
Contributor Author

Thanks Dominik! :)

@tomasstrba tomasstrba merged commit efc0320 into develop Mar 30, 2022
@tomasstrba tomasstrba deleted the tom/tab-preview branch March 30, 2022 09:13
samsymons added a commit that referenced this pull request Apr 4, 2022
# By Tomas Strba (5) and others
# Via GitHub
* develop:
  Refresh the Autofill panel after importing (#496)
  Require authentication for login export (#494)
  Observations database clearing improvements (#495)
  Fix handling external schemes in address bar (#493)
  New autoconsent rules and move tab cleanup out of onCommitted (#489)
  Safari CSV Passwords import +LastPass, 1Password (#483)
  Split preferences into multiple screens and add an option to show full URL (#487)
  Color of hover label fixed (#497)
  Add AMP links protection (#488)
  Enhancements of fire button options (#484)
  Rename Logins+ to Autofill (#492)
  new tab page low hanging fruit (#491)
  Fix threading issues in Autoconsent (#478)
  Navigation bar improvement: CMD + back or CMD + forward opens a new tab (#486)
  TextField refactored to TextView in order to make it scrollable (#481)
  More Xcode cleaning (#485)

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants