Add AMP links protection #488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
SlayterDev
reviewed
Mar 29, 2022
There was a problem hiding this comment.
Please check the implementation guidelines for this feature. I do not see where we're attaching ampUrl to breakage reports. As well we need to attach urlParametersRemoved when this is set as well.
tomasstrba
reviewed
Mar 30, 2022
| onLinkRewrite: { [weak self] url, navigationAction in | ||
| let navigationActionPolicy = await linkProtection.requestTrackingLinkRewrite(initiatingURL: webView.url, | ||
| navigationAction: navigationAction, | ||
| onExtracting: { isAMPProtectionExtracting = true }, |
There was a problem hiding this comment.
Would be great if isAMPProtectionExtracting is handled only in this callback. The reason is you are setting it to false every time webview finishes loading (often unnecessary). Then isAMPProtectionExtracting publishes unnecessary events and triggers unnecessary recompilations of properties in ViewModel than may trigger unnecessary redrawing of View
SlayterDev
approved these changes
Mar 30, 2022
samsymons
added a commit
that referenced
this pull request
Apr 4, 2022
# By Tomas Strba (5) and others # Via GitHub * develop: Refresh the Autofill panel after importing (#496) Require authentication for login export (#494) Observations database clearing improvements (#495) Fix handling external schemes in address bar (#493) New autoconsent rules and move tab cleanup out of onCommitted (#489) Safari CSV Passwords import +LastPass, 1Password (#483) Split preferences into multiple screens and add an option to show full URL (#487) Color of hover label fixed (#497) Add AMP links protection (#488) Enhancements of fire button options (#484) Rename Logins+ to Autofill (#492) new tab page low hanging fruit (#491) Fix threading issues in Autoconsent (#478) Navigation bar improvement: CMD + back or CMD + forward opens a new tab (#486) TextField refactored to TextView in order to make it scrollable (#481) More Xcode cleaning (#485) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/72649045549333/1201716942816245/f
Tech Design URL: https://app.asana.com/0/481882893211075/1201948311080451/f
CC: @tomasstrba
Description:
AMP Protection introduced to macOS browser.
Steps to test this PR:
Testing checklist: