Use Timeout to Account for Async Rendering of Properties Panel #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippfromme
changed the title
philippfromme
force-pushed
the
fix-focus
branch
from
e79c0b2 to
a359a7d
Compare
philippfromme
force-pushed
the
fix-focus
branch
from
a359a7d to
dfc0e30
Compare
|
I will look into this today. |
barmac
reviewed
Sep 22, 2022
barmac
reviewed
Sep 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Due to the issue described in bpmn-io/properties-panel#186 (comment) the properties panel isn't always focused on
showEntry. To fix this issue a timeout is introduced to account for the async rendering of the properties panel. Once the issue has been fixed in the properties panel the timeout can be safely removed. In the meantime, nothing is going to change for users of@camunda/lintingas the timeout is only used internally.Related to bpmn-io/properties-panel#186
Related to camunda/camunda-modeler#3144