Do Not Account for Async Rendering of Properties Panel #186
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Due to the async rendering of React applications subscribing to events within a component isn't reliable as the event might already have been fired when the component is rendered and subscribes. As discussed with @nikku events should be subscribed to outside of the React application and relevant information should be passed to the application through props.
Sketch
This requires a bigger implementation effort. In the meantime, to fix this issue, the following changes have been made:
useEventBuffer
hookuseEffect
instead ofuseLayoutEffect
These changes remove some of the magic 🧙🏻♂️ that was added to work around the issue described above. The async rendering will be accounted for by camunda/linting#19.
Related to camunda/camunda-modeler#3144