Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: update modeling dependencies #3150

Merged
merged 1 commit into from
Sep 26, 2022
Merged

deps: update modeling dependencies #3150

merged 1 commit into from
Sep 26, 2022

Conversation

philippfromme
Copy link
Contributor

@philippfromme philippfromme commented Sep 22, 2022 •
edited
Loading

@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Sep 22, 2022
@nikku
Copy link
Member

nikku commented Sep 23, 2022

Does this close some other issues we have marked as fixed upstream? If so, let's double check and mark accordingly in the commit.

nikku
nikku requested changes Sep 23, 2022
View reviewed changes
Copy link
Member

@nikku nikku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please double check if other fixed upstream issues are closed by this.

@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed needs review Review pending labels Sep 23, 2022
@philippfromme philippfromme force-pushed the update-dependencies branch 2 times, most recently from d12cf93 to f52047d Compare September 23, 2022 09:02
@philippfromme
Copy link
Contributor Author

I included another fix (cf. camunda/linting#19) and updated the commit message to close all related issues.

@philippfromme philippfromme requested a review from nikku September 23, 2022 09:05
@nikku nikku merged commit 56e1d43 into develop Sep 26, 2022
@nikku nikku deleted the update-dependencies branch September 26, 2022 18:40
@bpmn-io-tasks bpmn-io-tasks bot removed the in progress Currently worked on label Sep 26, 2022
@nikku nikku mentioned this pull request Sep 26, 2022
Closed
13 tasks
@philippfromme philippfromme mentioned this pull request Sep 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikku nikku nikku approved these changes

@marstamm marstamm Awaiting requested review from marstamm

@pinussilvestrus pinussilvestrus Awaiting requested review from pinussilvestrus

@barmac barmac Awaiting requested review from barmac

Assignees

@philippfromme philippfromme

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@philippfromme @nikku