Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update melange install #3

Conversation

jchavarri
Copy link
Collaborator

@jchavarri jchavarri commented Dec 15, 2022

  • Latest changes from main
  • Review requests

jchavarri and others added 30 commits November 30, 2022 15:43
Fixes merlin support when using the melange ppx

Signed-off-by: Javier Chavarri <[email protected]>
do not "guess" object names when generating link time modules.
Actually look up the generated module and find the object name

Signed-off-by: Rudi Grinberg <[email protected]>
Before we were failing if for some reason `coqc --config` failed when
selecting the native mode. This makes it so that if for whatever
reason `coqc --config` doesn't succeed then we default to vo mode.

Signed-off-by: Ali Caglayan <[email protected]>

<!-- ps-id: b7e30052-8c48-411a-b2b1-32b3b60604f8 -->
Signed-off-by: Ali Caglayan <[email protected]>

<!-- ps-id: 129abed9-a062-4703-b137-3ff66df359c2 -->
appveyor was not working AFAIK.

Signed-off-by: Ali Caglayan <[email protected]>
Signed-off-by: Etienne Millon <[email protected]>

Signed-off-by: Etienne Millon <[email protected]>
<!-- ps-id: 8f83bbdb-4bbb-4c1f-8c9a-c3d6b276346a -->

Signed-off-by: Ali Caglayan <[email protected]>
Signed-off-by: Ali Caglayan <[email protected]>

<!-- ps-id: f6470070-0fee-45e9-8931-6cad03c07cf6 -->
I explained these patterns to newcomers recently so I think they make
sense to be included in our guide.

Signed-off-by: Etienne Millon <[email protected]>

Signed-off-by: Etienne Millon <[email protected]>
* target hint: only load targets from subdir

This is an optimization: instead of loading all targets and filtering,
we start with only the right subdirectory.

Signed-off-by: Etienne Millon <[email protected]>

* Use a Code_error

Signed-off-by: Etienne Millon <[email protected]>

* fix typo

Signed-off-by: Etienne Millon <[email protected]>

Signed-off-by: Etienne Millon <[email protected]>
We also do some cleanup of the documentation. This will make adding
more subcommands easier in the future.

closes ocaml#4471

<!-- ps-id: 60b331a0-d183-498b-9bba-5ea3d4538fb2 -->

Signed-off-by: Ali Caglayan <[email protected]>
data_only_dirs can also define libraries using (subdir ..)

Signed-off-by: Rudi Grinberg <[email protected]>
reproduce the issue in PR ocaml#6633

link time code generation doesn't use the correct compilation closure
for the build info module. It uses the compile closure but we should use
the link closure

Signed-off-by: Rudi Grinberg <[email protected]>
correctly set the includes when computing the compilation context for
link time modules

Signed-off-by: Rudi Grinberg <[email protected]>
add test showing inline_tests are broken in js when using whole_program
compilation

Signed-off-by: Hugo Heuzard <[email protected]>
<!-- ps-id: 26ac0a58-418a-4d90-8e70-bfdeadac1a14 -->

Signed-off-by: Ali Caglayan <[email protected]>
for consistency of how we handle external libraries

Signed-off-by: Rudi Grinberg <[email protected]>

ps-id: 5083d16b-7109-4ea7-9aa0-2ef688141dd6
Signed-off-by: Rudi Grinberg <[email protected]>

ps-id: 8bc782de-6d34-4eb0-a0de-e5a9c590338b
Signed-off-by: Etienne Millon <[email protected]>

Signed-off-by: Etienne Millon <[email protected]>
rgrinberg and others added 22 commits December 12, 2022 22:07
now it allows generating rules in addition to redirecting

Signed-off-by: Rudi Grinberg <[email protected]>
correctly parse alerts and add a new severity kind

Signed-off-by: Rudi Grinberg <[email protected]>
We also add italic to ansi_color.

Signed-off-by: Ali Caglayan <[email protected]>
remove some native code remnants

Signed-off-by: Rudi Grinberg <[email protected]>
Use [Dir_contents.modules_of_lib]. This function will work once external
libraries are also supported.

Signed-off-by: Rudi Grinberg <[email protected]>
This is so that it is formatted correctly if it appears in a Pp.vbox.

Signed-off-by: Ali Caglayan <[email protected]>
It moved from @samoht to @ocamllabs to @tarides now.

Signed-off-by: Marek Kubica <[email protected]>

Signed-off-by: Marek Kubica <[email protected]>
To avoid the [Env] depending on [Path]

Signed-off-by: Rudi Grinberg <[email protected]>
Now it lives in its own module. Later to be decoupled from [Scheduler]

Signed-off-by: Rudi Grinberg <[email protected]>
* Remove a pointer indirection for code parsed
* Get rid of a lot of intermediate strings when printing codes

Signed-off-by: Rudi Grinberg <[email protected]>
Save some syscalls when detecting the functionality of the tty

Signed-off-by: Rudi Grinberg <[email protected]>
[allow_overlaps] and [forbidden_libraries] must always be provided

Signed-off-by: Rudi Grinberg <[email protected]>
@anmonteiro anmonteiro merged commit a936818 into anmonteiro:anmonteiro/melange-install Dec 17, 2022
@jchavarri jchavarri deleted the jchavarri/melange-install branch December 19, 2022 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants