Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: Redirect_to_parent improved #6637

Merged
merged 1 commit into from
Dec 13, 2022
Merged

feature: Redirect_to_parent improved #6637

merged 1 commit into from
Dec 13, 2022

Conversation

rgrinberg
Copy link
Member

now it allows generating rules in addition to redirecting

Signed-off-by: Rudi Grinberg [email protected]

ps-id: c63babc4-cd24-4d16-8c49-b1e4de16660e

@rgrinberg rgrinberg requested a review from snowleopard December 5, 2022 17:38
snowleopard
snowleopard reviewed Dec 7, 2022
View reviewed changes
Copy link
Collaborator

@snowleopard snowleopard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! I left a few, mostly stylistic suggestions.

@rgrinberg
Copy link
Member Author

Addressed all the comments

@snowleopard
Copy link
Collaborator

Addressed all the comments

Hmm, I don't see the changes. Have you forgot to push them?

@rgrinberg rgrinberg force-pushed the ps/rr/feature__redirect_to_parent_improved branch from 89f3878 to 48ad9fd Compare December 11, 2022 15:57
@rgrinberg
Copy link
Member Author

Whoops, I forgot. Pushed now.

snowleopard
snowleopard approved these changes Dec 13, 2022
View reviewed changes
Copy link
Collaborator

@snowleopard snowleopard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Added a few more suggestions but I don't think I need to review again.

@rgrinberg
feature: Redirect_to_parent improved
43bdbca 
now it allows generating rules in addition to redirecting

Signed-off-by: Rudi Grinberg <[email protected]>

ps-id: c63babc4-cd24-4d16-8c49-b1e4de16660e
@rgrinberg rgrinberg force-pushed the ps/rr/feature__redirect_to_parent_improved branch from 48ad9fd to 43bdbca Compare December 13, 2022 04:06
@rgrinberg rgrinberg merged commit 08a2904 into main Dec 13, 2022
@rgrinberg rgrinberg deleted the ps/rr/feature__redirect_to_parent_improved branch December 13, 2022 04:07
@anmonteiro anmonteiro mentioned this pull request Mar 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snowleopard snowleopard snowleopard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rgrinberg @snowleopard