WIP weird error when compiling executable #6633
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ali Caglayan <[email protected]> <!-- ps-id: 367f270d-344f-482b-a6fa-44943619df81 -->
rgrinberg
added a commit
that referenced
this pull request
Dec 6, 2022
reproduce the issue in PR #6633 link time code generation doesn't use the correct compilation closure for the build info module. It uses the compile closure but we should use the link closure Signed-off-by: Rudi Grinberg <[email protected]> ps-id: 17ab080e-5060-4f3e-9f0c-20d74b58f6ce
rgrinberg
added a commit
that referenced
this pull request
Dec 6, 2022
reproduce the issue in PR #6633 link time code generation doesn't use the correct compilation closure for the build info module. It uses the compile closure but we should use the link closure Signed-off-by: Rudi Grinberg <[email protected]> ps-id: 17ab080e-5060-4f3e-9f0c-20d74b58f6ce
rgrinberg
added a commit
that referenced
this pull request
Dec 6, 2022
reproduce the issue in PR #6633 link time code generation doesn't use the correct compilation closure for the build info module. It uses the compile closure but we should use the link closure Signed-off-by: Rudi Grinberg <[email protected]> ps-id: 17ab080e-5060-4f3e-9f0c-20d74b58f6ce
rgrinberg
added a commit
that referenced
this pull request
Dec 6, 2022
reproduce the issue in PR #6633 link time code generation doesn't use the correct compilation closure for the build info module. It uses the compile closure but we should use the link closure Signed-off-by: Rudi Grinberg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I encountered a weird error during something I was working on. The problematic stanza is in doc/man/dune. Rudi said he would take a look at it.