Target hints: only load targets from subdir #6603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@snowleopard I implemented the suggestion in your CR regarding directory targets. I first tried to add "a, b (directory target)" but this wasn't printing because this relies on edit distance to determine which candidates to keep. So I just added a |
snowleopard
reviewed
Dec 4, 2022
snowleopard
reviewed
Dec 4, 2022
snowleopard
reviewed
Dec 4, 2022
snowleopard
reviewed
Dec 4, 2022
snowleopard
reviewed
Dec 4, 2022
This is an optimization: instead of loading all targets and filtering, we start with only the right subdirectory. Signed-off-by: Etienne Millon <[email protected]>
Signed-off-by: Etienne Millon <[email protected]>
Signed-off-by: Etienne Millon <[email protected]>
snowleopard
approved these changes
Dec 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main content of this PR is an optimization: instead of loading all targets and filtering, we start with only the right subdirectory.