Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(melange): simplify module handling #6682

Merged
merged 1 commit into from
Dec 13, 2022

Conversation

rgrinberg
Copy link
Member

Use [Dir_contents.modules_of_lib]. This function will work once external
libraries are also supported.

Signed-off-by: Rudi Grinberg [email protected]

ps-id: ae9c4956-1a2c-4f5d-be06-87411b6903be

Use [Dir_contents.modules_of_lib]. This function will work once external
libraries are also supported.

Signed-off-by: Rudi Grinberg <[email protected]>

ps-id: ae9c4956-1a2c-4f5d-be06-87411b6903be
@rgrinberg rgrinberg requested a review from jchavarri December 13, 2022 03:13
Copy link
Collaborator

@anmonteiro anmonteiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have this in my install PR, too

Copy link
Collaborator

@jchavarri jchavarri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rgrinberg rgrinberg merged commit b358d47 into main Dec 13, 2022
@rgrinberg rgrinberg deleted the ps/rr/refactor_melange___simplify_module_handling branch December 13, 2022 14:30
@jchavarri jchavarri added the melange Melange rules and generator label Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
melange Melange rules and generator
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants