-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GECKO 3.0.2 #293
Merged
GECKO 3.0.2 #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: getECfromDatabase only change ecRxns entries
fix: minor enhancements in protocol
fix: read runDLKcat output
fix: correct update prot pool
fix: error if any match in customKcats
fix: if organism is in KEGG multiple times
feat: getStandardKcat use custom list of non-enzyme reactions to ignore
This PR has been automatically tested with GH Actions. Here is the output of the tests:
|
ae-tafur
approved these changes
Mar 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main improvements in this PR:
protocol.m
(solves Minor enhancement in protocol.m #279, Error in minimizing protein pool usage #287).model.ec.concs
and proteomics data) are in mg/gDCW.getStandardKcat
can usedata/pseudoRxns.tsv
as input of reactions to ignore, it overwrites previous standard Kcat definitions, and specifiesmodel.ec.source{i} = 'standard'
if a standard kcat is assigned to a zero-kcat reaction (solves getStandardKcat assigns protein costs to pseudo-reactions #280, ec.source in getStandardKcat #286)fuzzyKcatMatching
(solves Bug: Looks for the taxonomically closest organism for matching the Kcats #277),readDLKcatOutput
(solves Bug: check if DLKcat.tsv has actually been run through DLKcat #278),getECfromDatabase
(solves Bug detected getECfromDatabase #281),sensitivityTuning
(solves New feature sensitivityTuning #285), &applyCustomKcats
(solves Error in matching the custom Kcats #291).I hereby confirm that I have:
main
as a target branch (top left drop-down menu)