Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ec.source in getStandardKcat #286

Closed
Yu-sysbio opened this issue Mar 20, 2023 · 2 comments
Closed

ec.source in getStandardKcat #286

Yu-sysbio opened this issue Mar 20, 2023 · 2 comments
Assignees
Labels
enhancement fixed in develop Has already been addressed in develop branch

Comments

@Yu-sysbio
Copy link
Collaborator

getStandardKcat allows to assign kcats for reactions without any associated genes, and then mark in .ec.source with 'standard'.
It can also assign kcats for the reactions with genes but not assigned kcats by previous steps e.g. BRENDA and DLKcat, but the .ec.source is marked with empty, i.e. ''. I am wondering if this should also be marked with 'standard'.

Given that 'brenda' and 'dlkcat' mean the kcat source, does 'standard' mean the kcat itself, or the enzyme, kcat and molecular weight as a whole?

@ae-tafur
Copy link
Collaborator

I agree.

Given that 'brenda' and 'dlkcat' mean the kcat source, does 'standard' mean the kcat itself, or the enzyme, kcat and molecular weight as a whole?

It means the kcat itself

@ae-tafur ae-tafur self-assigned this Mar 20, 2023
@edkerk
Copy link
Member

edkerk commented Mar 20, 2023

I can fix this, while addressing #280.

@edkerk edkerk self-assigned this Mar 20, 2023
@ae-tafur ae-tafur removed their assignment Mar 20, 2023
edkerk added a commit that referenced this issue Mar 20, 2023
@edkerk edkerk added the fixed in develop Has already been addressed in develop branch label Mar 20, 2023
@edkerk edkerk mentioned this issue Mar 20, 2023
1 task
@edkerk edkerk closed this as completed Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement fixed in develop Has already been addressed in develop branch
Projects
None yet
Development

No branches or pull requests

3 participants