Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: getStandardKcat use custom list of non-enzyme reactions to ignore #288

Merged
merged 7 commits into from
Mar 20, 2023

Conversation

edkerk
Copy link
Member

@edkerk edkerk commented Mar 20, 2023

Main improvements in this PR:

I hereby confirm that I have:

  • Selected develop as a target branch (top left drop-down menu)

@edkerk edkerk requested a review from Yu-sysbio March 20, 2023 15:32
@edkerk edkerk added this to the 3.0.2 milestone Mar 20, 2023
@github-actions
Copy link

github-actions bot commented Mar 20, 2023

This PR has been automatically tested with GH Actions. Here is the output of the tests:

 
Running geckoCoreFunctionTests
================================================================================
Verification failed in geckoCoreFunctionTests/testsaveECModel_tc0009.
---------------------
Framework Diagnostic:
---------------------
verifyEqual failed.
--> Path to failure: .rev
--> The numeric values are not equal using "isequaln".
--> Failure table:
Index Actual Expected Error RelativeError
_____ ______ ________ _____ _____________

12 1 0 1 Inf
13 1 0 1 Inf
14 1 0 1 Inf
15 1 0 1 Inf
16 1 0 1 Inf
17 1 0 1 Inf

Actual double:
17x1 double
Expected double:
17x1 double

Actual Value:
struct with fields:

name: 'testModel'
id: 'testModel'
annotation: [1x1 struct]
date: '2023-03-20'
description: ''
version: ''
rxns: {17x1 cell}
S: [10x17 double]
rev: [17x1 double]
metNames: {10x1 cell}
comps: {2x1 cell}
compNames: {2x1 cell}
metComps: [10x1 double]
mets: {10x1 cell}
grRules: {17x1 cell}
rxnGeneMat: [17x5 double]
genes: {5x1 cell}
ub: [17x1 double]
lb: [17x1 double]
c: [17x1 double]
rxnNames: {17x1 cell}
b: [10x1 double]
eccodes: {17x1 cell}
metNotes: {10x1 cell}
ec: [1x1 struct]
Expected Value:
struct with fields:

id: 'testModel'
name: 'testModel'
description: ''
version: ''
date: '2023-03-20'
annotation: [1x1 struct]
rxns: {17x1 cell}
rxnNames: {17x1 cell}
mets: {10x1 cell}
metNames: {10x1 cell}
S: [10x17 double]
lb: [17x1 double]
ub: [17x1 double]
rev: [17x1 double]
c: [17x1 double]
b: [10x1 double]
genes: {5x1 cell}
grRules: {17x1 cell}
rxnGeneMat: [17x5 double]
eccodes: {17x1 cell}
metComps: [10x1 double]
metNotes: {10x1 cell}
comps: {2x1 cell}
compNames: {2x1 cell}
ec: [1x1 struct]
------------------
Stack Information:
------------------
In /home/m/actions-runner/_work/GECKO/GECKO/test/unit_tests/geckoCoreFunctionTests.m (testsaveECModel_tc0009) at 232
================================================================================
Model-specific DLKcat input stored at /home/m/actions-runner/_work/GECKO/GECKO/test/unit_tests/ecTestGEM/data/DLKcat_input_test.tsv
Limit has been reached. Protein P5 seems to be problematic. Consider changing the kcat.
Done geckoCoreFunctionTests
__________

Failure Summary:

Name Failed Incomplete Reason(s)
============================================================================================
geckoCoreFunctionTests/testsaveECModel_tc0009 X Failed by verification.

Note: In the case of multiple test runs, this post will be edited.

@edkerk edkerk requested a review from ae-tafur March 20, 2023 19:39
Copy link
Collaborator

@ae-tafur ae-tafur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@edkerk edkerk merged commit 0dfbffd into develop Mar 20, 2023
@edkerk edkerk deleted the fix/standardKcat branch March 20, 2023 20:04
Copy link
Collaborator

@Yu-sysbio Yu-sysbio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@edkerk edkerk restored the fix/standardKcat branch March 21, 2023 08:09
edkerk added a commit that referenced this pull request Mar 21, 2023
@edkerk edkerk mentioned this pull request Mar 21, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants