Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: check if DLKcat.tsv has actually been run through DLKcat #278

Closed
HossFir opened this issue Mar 9, 2023 · 1 comment
Closed

Bug: check if DLKcat.tsv has actually been run through DLKcat #278

HossFir opened this issue Mar 9, 2023 · 1 comment
Labels
fixed in develop Has already been addressed in develop branch

Comments

@HossFir
Copy link

HossFir commented Mar 9, 2023

@edkerk
Description:

I think this line should be uncommented. Otherwise, the Kcats found in the DLKcat.tsv were equal to NaN. (it was previously uncommented in the previous GECKO 3.0.0).

%runDLKcat();

@edkerk
Copy link
Member

edkerk commented Mar 9, 2023

Otherwise, the Kcats found in the DLKcat.tsv were equal to NaN.

Otherwise DLKcat does not run, and DLKcat.tsv is just the original input file. Will implement a check for this, and uncomment that line (which was commented ou to avoid Docker starting every time during testing).

@edkerk edkerk changed the title Bug: Matching Kcat using Docker image Bug: check if DLKcat.tsv has actually been run through DLKcat Mar 9, 2023
@edkerk edkerk added the fixed in develop Has already been addressed in develop branch label Mar 20, 2023
@edkerk edkerk mentioned this issue Mar 20, 2023
1 task
@edkerk edkerk closed this as completed Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixed in develop Has already been addressed in develop branch
Projects
None yet
Development

No branches or pull requests

2 participants