Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug detected getECfromDatabase #281

Closed
Yu-sysbio opened this issue Mar 15, 2023 · 0 comments
Closed

Bug detected getECfromDatabase #281

Yu-sysbio opened this issue Mar 15, 2023 · 0 comments
Assignees
@edkerk
Labels
bug fixed in develop Has already been addressed in develop branch

Comments

@Yu-sysbio
Copy link
Collaborator

The input ecRxns of the function getECfromDatabase seems to be ineffective.

I found this bug when I ran Line 89 in the protocol: many EC numbers that were obtained by getECfromGEM were modified by getECfromDatabase even though they showed FALSE in noEC. And using getECfromDatabase(ecModel,noEC) and getECfromDatabase(ecModel) showed identical results.
@Yu-sysbio Yu-sysbio added the bug label Mar 15, 2023
@edkerk edkerk self-assigned this Mar 15, 2023
@edkerk edkerk mentioned this issue Mar 15, 2023
Merged
1 task
@edkerk edkerk added the fixed in develop Has already been addressed in develop branch label Mar 17, 2023
@edkerk edkerk mentioned this issue Mar 20, 2023
Merged
1 task
@edkerk edkerk closed this as completed Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@edkerk edkerk

Labels
bug fixed in develop Has already been addressed in develop branch
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@edkerk @Yu-sysbio