Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove drake_export.h #3973

Closed
jwnimmer-tri opened this issue Nov 1, 2016 · 4 comments
Closed

Remove drake_export.h #3973

jwnimmer-tri opened this issue Nov 1, 2016 · 4 comments

Comments

@jwnimmer-tri
Copy link
Collaborator

jwnimmer-tri commented Nov 1, 2016

Per #3965, we need to bake some perl pie and remove the include file itself, as well as the DRAKE_EXPORT annotations.

@jwnimmer-tri
Copy link
Collaborator Author

Ongoing use is causing compiler warnings (marking a symbol public when it already is). I'm going to at least remove the use of the macro. Then we can delete the file in a second step (to allow for easier downstream transitions).

soonho-tri added a commit to soonho-tri/drake that referenced this issue Nov 11, 2016
soonho-tri added a commit to soonho-tri/drake that referenced this issue Nov 11, 2016
@jwnimmer-tri
Copy link
Collaborator Author

Dropping priority; the only remaining task is to rm the header file at some unspecified future date. (For example, once feature branches that depend on it get updated to account for the new deprecation warning that will show up.)

@jwnimmer-tri
Copy link
Collaborator Author

Apparently my #4292 magic phrase didn't auto-close this, but this issue is resolved now.

@liangfok
Copy link
Contributor

Looks like the magic phrase only works when it's in the OP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants