Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove DRAKE_EXPORT from examples #4073

Conversation

jwnimmer-tri
Copy link
Collaborator

@jwnimmer-tri jwnimmer-tri commented Nov 8, 2016

Remove DRAKE_EXPORT from a examples. This is a portion of #3973.


This change is Reviewable

@jwnimmer-tri
Copy link
Collaborator Author

+@sammy-tri has accepted my invitation to review these. Thanks!


Review status: 0 of 7 files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@jwnimmer-tri jwnimmer-tri force-pushed the build-drake_export-remove-uses-pr7 branch from b64ef62 to bc0fe4a Compare November 8, 2016 17:51
@sammy-tri
Copy link
Contributor

Reviewed 6 of 7 files at r1.
Review status: 6 of 7 files reviewed at latest revision, 3 unresolved discussions.


drake/examples/Atlas/atlasUtil.h, line 3 at r1 (raw file):

#pragma once

#include "drake/common/drake_export.h"

Remove this too?


drake/examples/Pendulum/pendulum_swing_up.h, line 5 at r1 (raw file):

#include <memory>

#include "drake/common/drake_export.h"

Remove include as well?


drake/examples/schunk_gripper/simulated_schunk_system.cc, line 3 at r1 (raw file):

#include "drake/examples/schunk_gripper/simulated_schunk_system.h"

#include "drake/common/drake_export.h"

Remove include also?


Comments from Reviewable

@sammy-tri
Copy link
Contributor

Reviewed 1 of 7 files at r1.
Review status: all files reviewed at latest revision, 3 unresolved discussions.


Comments from Reviewable

@jwnimmer-tri jwnimmer-tri force-pushed the build-drake_export-remove-uses-pr7 branch from bc0fe4a to 9624a78 Compare November 8, 2016 18:17
@jwnimmer-tri
Copy link
Collaborator Author

Review status: 4 of 10 files reviewed at latest revision, 3 unresolved discussions.


drake/examples/Atlas/atlasUtil.h, line 3 at r1 (raw file):

Previously, sammy-tri wrote…

Remove this too?

Done.

drake/examples/Pendulum/pendulum_swing_up.h, line 5 at r1 (raw file):

Previously, sammy-tri wrote…

Remove include as well?

Done.

drake/examples/schunk_gripper/simulated_schunk_system.cc, line 3 at r1 (raw file):

Previously, sammy-tri wrote…

Remove include also?

Done.

Comments from Reviewable

@sammy-tri
Copy link
Contributor

:lgtm:


Reviewed 6 of 6 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@jwnimmer-tri jwnimmer-tri merged commit c361f89 into RobotLocomotion:master Nov 8, 2016
@jwnimmer-tri jwnimmer-tri deleted the build-drake_export-remove-uses-pr7 branch November 8, 2016 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants