Remove DRAKE_EXPORT from template class instantiations #4048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that visibility:public is the project-wide default, many of these cause build warnings. This commit was an entirely automated change, via: find drake ros -name '*.h' -print0 -o -name '*.cc' -print0 -o -name '*.cpp' -print0 -o -name '*.py' -print0 | xargs -n1 -0 perl -pi -e 's#template class DRAKE_EXPORT#template class#g;'jwnimmer@call-cc:~/jwnimmer-tri/drake-distro$
jwnimmer-tri
changed the title
|
Reviewed 31 of 31 files at r1. Comments from Reviewable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the portion of #3973 that is actively generating warnings.
Note that some include statements may be vestigial now. Trust that a future PR will remove all includes of drake_export.h from within the project.
See prior discussion in #3668.
Label "curate" because this PR should squash-and-merge.
This change is