Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove DRAKE_EXPORT from solvers #4064

Conversation

jwnimmer-tri
Copy link
Collaborator

@jwnimmer-tri jwnimmer-tri commented Nov 8, 2016

Remove DRAKE_EXPORT from solvers. This is a portion of #3973.


This change is Reviewable

@drake-jenkins-bot
Copy link

Can one of the admins verify this patch?

@jwnimmer-tri
Copy link
Collaborator Author

@drake-jenkins-bot retest this please

@jwnimmer-tri
Copy link
Collaborator Author

+@sammy-tri for all review, please.


Review status: 0 of 19 files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@jwnimmer-tri jwnimmer-tri force-pushed the build-drake_export-remove-uses-pr5 branch from ab8a140 to 1c1afbd Compare November 8, 2016 14:52
@sammy-tri
Copy link
Contributor

:lgtm: (if we're gonna shut the door, might as well slam it closed I guess...)


Reviewed 19 of 19 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@jwnimmer-tri jwnimmer-tri merged commit 9f09c77 into RobotLocomotion:master Nov 8, 2016
@jwnimmer-tri jwnimmer-tri deleted the build-drake_export-remove-uses-pr5 branch November 8, 2016 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants