Next/20220325/v1 #7172
Merged
Next/20220325/v1 #7172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These tests are reimplemented in Suricata-Verify Task: 4911
Ticket: 4972 Completes commit c3a2206 DETECT_CONFIG is added as DETECT_SM_LIST_POSTMATCH and not as DETECT_SM_LIST_MATCH as other keywords handled in SignatureCreateMask
Add debug validation checks for "impossible" conditions.
Fix parsing of content like "|aa b cc|" which was parsed as "|aa bc|" without error or warning. This will now fail out, requiring all hex values to be 2 chars. Ticket OISF#5201
Even if the code seems unreachable for now
Coverity ID: 1502953 As we check just on the next line my_pool against NULL, we should not dereference it, even for debug validation
Ticket: 4948 When parsing the response for starttls
Closed
|
Information: QA ran without warnings. Pipeline 6655 |
This was referenced Mar 27, 2022
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Staging:
Additionally, removes dead code from the streaming buffer API to simplify error handling.
Fixes #7171, fixing formatting
Replaces #7155