Coverity fixes v2 #7138
Closed
Coverity fixes v2 #7138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even if the code seems unreachable for now
Coverity ID: 1502953 As we check just on the next line my_pool against NULL, we should not dereference it, even for debug validation
Closed
|
Information:
Pipeline 6573 |
Codecov Report
@@ Coverage Diff @@
## master #7138 +/- ##
==========================================
+ Coverage 78.06% 78.15% +0.08%
==========================================
Files 628 628
Lines 185266 185268 +2
==========================================
+ Hits 144635 144787 +152
+ Misses 40631 40481 -150
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
CI failure seems unrelated |
| @@ -813,6 +813,9 @@ Flow *FlowGetFlowFromHash(ThreadVars *tv, FlowLookupStruct *fls, | |||
| if (f->use_cnt == 0) { | |||
| if (prev_f == NULL) /* if we have no prev it means new_f is now our prev */ | |||
| prev_f = new_f; | |||
| // f got unlocked by TcpReuseReplace and will be unlocked again by | |||
| // MoveToWorkQueue | |||
| FromHashLockCMP(f); | |||
There was a problem hiding this comment.
I think I prefer not unlocking the old flow in TcpReuseReplace
Closed
|
Replaced by #7169 |
|
Merged all but the flow commit in #7172, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to redmine ticket:
None, not sure it deserves one
Describe changes: patches to make coverity happy
PKT_IS_IPV6orPKT_IS_IPV4)PacketPoolDestroyAfter this and #7131 (which I think is a real bug this one), there will be no more outstanding issues reported by coverity
Replaces #7132 with review taken into account + new bug found by coverity meanwhile