smtp: check if there is a transaction to close

[catenacyber]

Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/4948

Describe changes:

• smtp: check if there is a transaction to close (for starttls)

[codecov]

Codecov Report

Merging #7050 (9c356e1) into master (b1c0936) will decrease coverage by 2.41%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #7050      +/-   ##
==========================================
- Coverage   77.88%   75.46%   -2.42%     
==========================================
  Files         628      628              
  Lines      185373   185243     -130     
==========================================
- Hits       144374   139792    -4582     
- Misses      40999    45451    +4452     

Flag	Coverage Δ
fuzzcorpus	54.48% <100.00%> (-4.02%)	⬇️
suricata-verify	54.44% <100.00%> (-0.11%)	⬇️
unittests	63.17% <100.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

[suricata-qa]

Information: QA ran without warnings.

Pipeline 6397

[inashivb]

Do we have an s-v test as mentioned on the issue for this? The change looks fine on the first sight.

[catenacyber]

Do we have an s-v test as mentioned on the issue for this? The change looks fine on the first sight.

There is none for the moment.
I confess I rely on oss-fuzz for regressions testing on the issues it finds
I could craft one S-V test if needed out of the oss-fuzz reproducer

[victorjulien]

Do we have an s-v test as mentioned on the issue for this? The change looks fine on the first sight.

There is none for the moment. I confess I rely on oss-fuzz for regressions testing on the issues it finds I could craft one S-V test if needed out of the oss-fuzz reproducer

Can you craft such a test?

[catenacyber]

Can you craft such a test?

Done in OISF/suricata-verify#784

[victorjulien]

Merged in #7172, thanks!