-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Next/20220321/v4 #7155
Closed
Closed
Next/20220321/v4 #7155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These tests are reimplemented in Suricata-Verify Task: 4911
Ticket: 4972 Completes commit c3a2206 DETECT_CONFIG is added as DETECT_SM_LIST_POSTMATCH and not as DETECT_SM_LIST_MATCH as other keywords handled in SignatureCreateMask
Add debug validation checks for "impossible" conditions.
Closed
Codecov Report
@@ Coverage Diff @@
## master #7155 +/- ##
==========================================
+ Coverage 78.06% 78.09% +0.02%
==========================================
Files 628 628
Lines 185266 184533 -733
==========================================
- Hits 144635 144117 -518
+ Misses 40631 40416 -215
Flags with carried forward coverage won't be shown. Click here to find out more. |
Information:
Pipeline 6634 |
Merged
Merged in #7172 |
victorjulien
pushed a commit
to victorjulien/suricata
that referenced
this pull request
Jul 9, 2024
Inspired by a recent Zeek blog post, this could speed up PCAP processing by a few percent. Ticket: OISF#7155.
victorjulien
added a commit
to victorjulien/suricata
that referenced
this pull request
Jul 9, 2024
Make optional through `pcap-file.buffer-size` config option. Make sure to check through configure. Ticket: OISF#7155.
victorjulien
added a commit
to victorjulien/suricata
that referenced
this pull request
Jul 9, 2024
Allows easy specification of buffer size on the commandline. Ticket: OISF#7155.
victorjulien
pushed a commit
to victorjulien/suricata
that referenced
this pull request
Jul 10, 2024
Inspired by a recent Zeek blog post, this could speed up PCAP processing by a few percent. Ticket: OISF#7155.
victorjulien
added a commit
to victorjulien/suricata
that referenced
this pull request
Jul 10, 2024
Make optional through `pcap-file.buffer-size` config option. Make sure to check through configure. Ticket: OISF#7155.
victorjulien
added a commit
to victorjulien/suricata
that referenced
this pull request
Jul 10, 2024
Allows easy specification of buffer size on the commandline. Ticket: OISF#7155.
victorjulien
pushed a commit
to victorjulien/suricata
that referenced
this pull request
Aug 8, 2024
Inspired by a recent Zeek blog post, this could speed up PCAP processing by a few percent. Ticket: OISF#7155.
victorjulien
added a commit
to victorjulien/suricata
that referenced
this pull request
Aug 8, 2024
Make optional through `pcap-file.buffer-size` config option. Make sure to check through configure. Ticket: OISF#7155.
victorjulien
added a commit
to victorjulien/suricata
that referenced
this pull request
Aug 8, 2024
Allows easy specification of buffer size on the commandline. Ticket: OISF#7155.
victorjulien
pushed a commit
to victorjulien/suricata
that referenced
this pull request
Aug 30, 2024
Inspired by a recent Zeek blog post, this could speed up PCAP processing by a few percent. Ticket: OISF#7155.
victorjulien
added a commit
to victorjulien/suricata
that referenced
this pull request
Aug 30, 2024
Make optional through `pcap-file.buffer-size` config option. Make sure to check through configure. Ticket: OISF#7155.
victorjulien
added a commit
to victorjulien/suricata
that referenced
this pull request
Aug 30, 2024
Allows easy specification of buffer size on the commandline. Ticket: OISF#7155.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Staging:
Additionally, removes dead code from the streaming buffer API to simplify error handling.
Replaces #7154 to fix formatting.