Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next/20220321/v4 #7155

Closed
wants to merge 3 commits into from
Closed

Conversation

victorjulien
Copy link
Member

Staging:

Additionally, removes dead code from the streaming buffer API to simplify error handling.

Replaces #7154 to fix formatting.

TheKharleeci and others added 3 commits March 21, 2022 15:32
These tests are reimplemented in Suricata-Verify

Task: 4911
Ticket: 4972

Completes commit c3a2206

DETECT_CONFIG is added as DETECT_SM_LIST_POSTMATCH and not
as DETECT_SM_LIST_MATCH as other keywords handled in SignatureCreateMask
Add debug validation checks for "impossible" conditions.
@victorjulien victorjulien requested a review from a team as a code owner March 21, 2022 21:10
@victorjulien victorjulien mentioned this pull request Mar 21, 2022
@codecov
Copy link

codecov bot commented Mar 21, 2022

Codecov Report

Merging #7155 (9be60c7) into master (3a490fb) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #7155      +/-   ##
==========================================
+ Coverage   78.06%   78.09%   +0.02%     
==========================================
  Files         628      628              
  Lines      185266   184533     -733     
==========================================
- Hits       144635   144117     -518     
+ Misses      40631    40416     -215     
Flag Coverage Δ
fuzzcorpus 60.39% <100.00%> (+0.40%) ⬆️
suricata-verify 54.59% <75.00%> (-0.01%) ⬇️
unittests 62.94% <97.29%> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

This was referenced Mar 22, 2022
@suricata-qa
Copy link

Information:

field test baseline %
tlpr1_stats_chk
.flow.memuse 552019648 513860928 107.43%

Pipeline 6634

@victorjulien victorjulien mentioned this pull request Mar 25, 2022
@victorjulien
Copy link
Member Author

Merged in #7172

@victorjulien victorjulien deleted the next/20220321/v4 branch April 14, 2022 13:18
victorjulien pushed a commit to victorjulien/suricata that referenced this pull request Jul 9, 2024
Inspired by a recent Zeek blog post, this could speed up PCAP
processing by a few percent.

Ticket: OISF#7155.
victorjulien added a commit to victorjulien/suricata that referenced this pull request Jul 9, 2024
Make optional through `pcap-file.buffer-size` config option.

Make sure to check through configure.

Ticket: OISF#7155.
victorjulien added a commit to victorjulien/suricata that referenced this pull request Jul 9, 2024
Allows easy specification of buffer size on the commandline.

Ticket: OISF#7155.
victorjulien pushed a commit to victorjulien/suricata that referenced this pull request Jul 10, 2024
Inspired by a recent Zeek blog post, this could speed up PCAP
processing by a few percent.

Ticket: OISF#7155.
victorjulien added a commit to victorjulien/suricata that referenced this pull request Jul 10, 2024
Make optional through `pcap-file.buffer-size` config option.

Make sure to check through configure.

Ticket: OISF#7155.
victorjulien added a commit to victorjulien/suricata that referenced this pull request Jul 10, 2024
Allows easy specification of buffer size on the commandline.

Ticket: OISF#7155.
victorjulien pushed a commit to victorjulien/suricata that referenced this pull request Aug 8, 2024
Inspired by a recent Zeek blog post, this could speed up PCAP
processing by a few percent.

Ticket: OISF#7155.
victorjulien added a commit to victorjulien/suricata that referenced this pull request Aug 8, 2024
Make optional through `pcap-file.buffer-size` config option.

Make sure to check through configure.

Ticket: OISF#7155.
victorjulien added a commit to victorjulien/suricata that referenced this pull request Aug 8, 2024
Allows easy specification of buffer size on the commandline.

Ticket: OISF#7155.
victorjulien pushed a commit to victorjulien/suricata that referenced this pull request Aug 30, 2024
Inspired by a recent Zeek blog post, this could speed up PCAP
processing by a few percent.

Ticket: OISF#7155.
victorjulien added a commit to victorjulien/suricata that referenced this pull request Aug 30, 2024
Make optional through `pcap-file.buffer-size` config option.

Make sure to check through configure.

Ticket: OISF#7155.
victorjulien added a commit to victorjulien/suricata that referenced this pull request Aug 30, 2024
Allows easy specification of buffer size on the commandline.

Ticket: OISF#7155.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants