Fixes/nfs files/v1 #5201
Closed
Fixes/nfs files/v1 #5201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case of lossy connections the NFS state would properly clean up transactions, including file transactions. However for files the state was never set to 'truncated', leading to files to stay 'active'. This would lead these files staying in the NFS's state. In long running sessions with lots of files this would lead to performance and memory use issues. This patch cleans truncates the file that was being transmitted when a file transaction is being closed. Based on 65e9a7c
|
Merged in #5207 |
jasonish
added a commit
to jasonish/suricata
that referenced
this pull request
Mar 22, 2022
Fix parsing of content like "|aa b cc|" which was parsed as "|aa bc|" without error or warning. This will now fail out, requiring all hex values to be 2 chars. Ticket OISF#5201
jasonish
added a commit
to jasonish/suricata
that referenced
this pull request
Mar 22, 2022
Fix parsing of content like "|aa b cc|" which was parsed as "|aa bc|" without error or warning. This will now fail out, requiring all hex values to be 2 chars. Ticket OISF#5201
jasonish
added a commit
to jasonish/suricata
that referenced
this pull request
Mar 22, 2022
Fix parsing of content like "|aa b cc|" which was parsed as "|aa bc|" without error or warning. This will now fail out, requiring all hex values to be 2 chars. Ticket OISF#5201
jasonish
added a commit
to jasonish/suricata
that referenced
this pull request
Mar 23, 2022
Fix parsing of content like "|aa b cc|" which was parsed as "|aa bc|" without error or warning. This will now fail out, requiring all hex values to be 2 chars. Ticket OISF#5201
victorjulien
pushed a commit
to victorjulien/suricata
that referenced
this pull request
Mar 25, 2022
Fix parsing of content like "|aa b cc|" which was parsed as "|aa bc|" without error or warning. This will now fail out, requiring all hex values to be 2 chars. Ticket OISF#5201
victorjulien
pushed a commit
to victorjulien/suricata
that referenced
this pull request
Mar 25, 2022
Fix parsing of content like "|aa b cc|" which was parsed as "|aa bc|" without error or warning. This will now fail out, requiring all hex values to be 2 chars. Ticket OISF#5201
victorjulien
pushed a commit
to victorjulien/suricata
that referenced
this pull request
Apr 19, 2022
catenacyber
pushed a commit
to catenacyber/suricata
that referenced
this pull request
Jun 7, 2022
Add a rule with incomplete hex, for example "|22 2 22|" which should result in a parse error. Ticket OISF#5201.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://redmine.openinfosecfoundation.org/issues/3700
PRScript output (if applicable):
Passed