Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Version 4.2 #2940

Closed
wants to merge 636 commits into from
Closed

[WIP] Version 4.2 #2940

wants to merge 636 commits into from

Conversation

tabacitu
Copy link
Member

@tabacitu tabacitu commented Jun 16, 2020

Dev branch. See the the 4.2 issue board for details.

Currently includes:

BREAKING:

@tabacitu tabacitu changed the title Version 4.2 [WIP] Version 4.2 Jun 29, 2020
@tabacitu
Copy link
Member Author

tabacitu commented Sep 6, 2021

@promatik could you please take a look at this and fix the merge conflicts? I know you worked with list.css last.
I want to start merging 4.2 fixes into the 4.2 branch, but not before we bring it up-to-date with master.

Thanks!

@promatik
Copy link
Contributor

promatik commented Sep 6, 2021

Done @tabacitu

So, this branch was already including #2891, and just to make it clear, it is different from #3331, that's another PR open for 4.2 with layout changes on CRUD table.

@tabacitu
Copy link
Member Author

tabacitu commented Sep 6, 2021

Excellent! We now have a working 4.2 branch. It's now locked, only I can do changes to it and merge to it, so please for 4.2 submit PRs to this 4.2 branch. Let's do this 💪

@promatik
Copy link
Contributor

promatik commented Sep 6, 2021

Perfect 👌
@tabacitu, previous 4.2 PRs, targeting master, should we point them to this 4.2 branch instead?

@tabacitu
Copy link
Member Author

tabacitu commented Sep 6, 2021

Exactly 🙏 But we'll do that one at a time, no problem.

@tabacitu tabacitu mentioned this pull request Oct 8, 2021
4 tasks
@tabacitu tabacitu assigned tabacitu and unassigned promatik Oct 25, 2021
pxpm and others added 20 commits February 2, 2022 11:35
[ci skip] [skip ci]
Make `select_multiple` and `select2_multiple` fields works as subfields and dot.notation.fields (through calling `create()` recursively)
Make fake fields work when used as subfields
…s-and-arrays-in-select-multiples

`old()` does not work in s/s2_multiple
[ci skip] [skip ci]
…ith-single-dimension-arrays

ensure table column works with associative arrays too
@scrutinizer-notifier
Copy link

The inspection completed: 570 Issues, 82 Patches

@tabacitu tabacitu mentioned this pull request Feb 4, 2022
Merged
@tabacitu tabacitu closed this Feb 4, 2022
@tabacitu
Copy link
Member Author

tabacitu commented Feb 4, 2022

Due to legal implications, we've had to rename v4.2 to v5. So let's close this branch in favor of that one - #4152

@tabacitu tabacitu reopened this Feb 4, 2022
@tabacitu tabacitu closed this Feb 4, 2022
@tabacitu tabacitu deleted the 4.2 branch February 4, 2022 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants