change default column limit to 32 #4119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tabacitu
added
Priority: MUST
Minor Bug
This was referenced Jan 25, 2022
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY
BEFORE - What was wrong? What was happening before this PR?
Issue #4118 was happening. The table was too wide on mobile sometimes:
AFTER - What is happening after this PR?
No longer too wide:
HOW
How did you achieve that, in technical terms?
The culprit was that the column
limitwas too big (40). Changed it to 32 and now it'll look good on most phones. It still won't look good on very small phones like iPhone 5, but I don't think we should optimize for those at this point.Is it a breaking change or non-breaking change?
Some would say breaking... I would say non-breaking. It's just a cosmetic change, after all.
How can we test the before & after?
Browse all CRUDs in the demo on mobile (using Chrome DevTools).