Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY
BEFORE - What was wrong? What was happening before this PR?
As reported in #3789, the
FormRequest
wasn't passed to the saving. So if you edited the request there, tough luck.AFTER - What is happening after this PR?
The
FormRequest
gets passed to the saving.HOW
Is it a breaking change or non-breaking change?
BREAKING
How can we test the before & after?
Do this in your FormRequest:
BEFORE this PR you'll notice it's ignored, it doesn't reach the saving part (if you
dd()
before it gets saved).AFTER this PR it does reach it.
Of course, then it will get stripped by
getStrippedSaveRequest()
, but that's a different problem, but you can do something like this then (and addupdated_by
to your validation rules asnullable
):