changed column three dots to ellipsis

[tabacitu]

WHY

BEFORE - What was wrong? What was happening before this PR?

Before this PR, I was a little bit sad & bored. So I decided to make someone happy today (not saying who 😉 ).

Also, when a column was truncated, it showed [...] at the end.

AFTER - What is happening after this PR?

It shows a … at the end instead.

HOW

How did you achieve that, in technical terms?

Find & replace.

Is it a breaking change or non-breaking change?

Non-breaking.

How can we test the before & after?

You don't:

[pxpm]

@tabacitu hahaha Santa is coming earlier this year :)

I am going to be the little green elf that will try to ruin the christmas this year, but when I see this kind of changes I think it would be better if this was a possible configuration of the columns, instead of changing one opinionated value for another one. I am not sure if ... indicates better than [...] that the text had been truncated. Depending on the content stored in the column the three dots could look more like part of a regular person writting than the brackets with dots. I've also seen (...) beeing used.

But probably there is some gramatical rule about it that I don't know, but beeing part of column configuration wouldn't hurt I guess.

Pedro

[promatik]

Yeah 🎉 😂

@tabacitu something that I haven't mention, with the Laravel-Backpack/editable-columns, since it uses <input>, it behaves different from the other default columns with <span> and <p>, so I added the text-overflow: ellipsis; there, to get this result;

This PR makes everything even 🙌
… is also the standard on HTML/CSS, so … everywhere 🎉

[tabacitu]

I am going to be the little green elf that will try to ruin the christmas this year

😅

I think it would be better if this was a possible configuration of the columns, instead of changing one opinionated value for another one

I totally agree. It should be a config. But when I did a search & replace I found that not all columns have a limit, so... doing it right would probably entail a lot more time spent on this, evaluating which columns should have it and which shouldn't... talking about WHEN and HOW to do that... bleah. We definitely don't have time to do that right now, since this is a COULD. So I just did a quick&dirty find&replace, that at least cleans things up visually a bit. I didn't mind the brackets either, but @promatik had a pretty big problem with them 😀

I've added an issue for this, to maybe make it configurable in 4.2.x or v12.x - (done here - Laravel-Backpack/community-forum#119 ). But the fact and the matter is... nobody asked for this yet. If nobody asked to make it configurable... we probably shouldn't. Otherwise... where do we stop?