Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mini sprint may 2019 #1226

Merged
merged 39 commits into from
May 17, 2019
Merged

Mini sprint may 2019 #1226

merged 39 commits into from
May 17, 2019

Conversation

todd-dembrey
Copy link
Contributor

This is first block of PRs from the mini-sprint.

Added features:

  • Comments are now editable in both the React app and the Django app by the original author
  • Users are notified if they try and leave the Submission Detail view whilst editing a comment
  • Batch determinations will navigate the user back to their starting location on completion of the determination
  • Submissions are consistently ordered between all views in By Round and By Status pages.
  • Reviewers are consistently ordered in the Detail View and React App. [Submissions Listings will be ordered by Reviewer ordering: list view #1191 - awaiting review]

Completed tickets:

closes #1130
closes #1142
closes #1192
closes #1214
closes #1193
closes #1194
closes #945

Related ticket:

#1108 Which is fixed by the work in #1219

Outstanding work from the sprint that is complete and is awaiting review:

#1215
#1216
#985 and the related #1191

chris-lawton and others added 30 commits May 7, 2019 11:47
…rigin-for-batch-determine

GH-1130: Redirect back to origin on batch determine
…wer-ordering

put people who don't have an order set after those who do
…iting-be

Make the comment editable through the API
…rouped-ordering

Feature/1142 detail view grouped ordering
…-constant

fix the timestamp changing between when a comment updates
@todd-dembrey todd-dembrey merged commit a4a9211 into master May 17, 2019
@todd-dembrey todd-dembrey deleted the mini-sprint-may-2019 branch August 27, 2019 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment