Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reviewer ordering: detailed view #1192

Closed
1 task done
gibbsmaya opened this issue May 7, 2019 · 3 comments · Fixed by #1226
Closed
1 task done

Reviewer ordering: detailed view #1192

gibbsmaya opened this issue May 7, 2019 · 3 comments · Fixed by #1226
Assignees

Comments

@gibbsmaya
Copy link

gibbsmaya commented May 7, 2019

Correct reviewer ordering is:

<role reviews submitted ordered by role order>
<staff reviews submitted>
<role not reviewed ordered by role order>
<staff not reviewed>
---
<external reviews>
<external not reviewed>

(Submission View currently correct)

Acceptance criteria

@abigail-hampson
Copy link

Issue:
Went into this submission (which had no reviewers assigned), added myself as primary and Chris as secondary reviewer. Reviewers got added but other reviewers and reviews are now displaying. This has happened on multiple submissions.
https://dev-apply.opentech.fund/apply/submissions/10/
Screen Shot 2019-05-09 at 10 53 33

Otherwise ordering looks good, can be deployed to test

@todd-dembrey
Copy link
Contributor

This is because you are testing on a concept note, their is no external review involved here so we do not show them. A proposals would be a good one to test the external reviewers.

@todd-dembrey todd-dembrey added the Status: Needs testing Tickets that need testing/qa label May 9, 2019
@fourthletter
Copy link
Contributor

Features are functional during test. Thanks! 💥

I tested applications in Community Lab and reviewers "Abigail" and "Di" are sequential in every view, i.e., list, detailed, and submission. https://test-apply.opentech.fund/apply/rounds/736/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants