Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort submission list in the react app by id just as the submission list view #1142

Closed
frjo opened this issue Mar 29, 2019 · 8 comments · Fixed by #1226
Closed

Sort submission list in the react app by id just as the submission list view #1142

frjo opened this issue Mar 29, 2019 · 8 comments · Fixed by #1226
Assignees
Labels
Type: Enhancement This is an improvement of an existing thing (not a new thing, which would be a feature).

Comments

@frjo
Copy link
Member

frjo commented Mar 29, 2019

The view at /apply/submissions/all/ sort submission by submission id.

The react app at /apply/rounds//? sort the submissions in the left column by latest activity.

We would like that to sort by submission id as well so the list is sorted the same in different views. Makes it easier to locate submissions.

@frjo frjo added Type: Enhancement This is an improvement of an existing thing (not a new thing, which would be a feature). apply labels Mar 29, 2019
@frjo frjo added this to the 2019-Q2 milestone Mar 29, 2019
@frjo frjo added the priority label Apr 25, 2019
@gibbsmaya gibbsmaya modified the milestones: 2019-Q2, Todd mini sprint Apr 26, 2019
@todd-dembrey
Copy link
Contributor

todd-dembrey commented Apr 26, 2019

@frjo if the issue is finding things in the list would we be better places to provide some means of search?

We also think the default sort order in django is activity, would it make sense to keep this default in the react app as well?

@frjo
Copy link
Member Author

frjo commented Apr 26, 2019

Search would be good as well but they really want the lists to be ordered the same way. Seems to be important for their workflow.

Sent with GitHawk

@gibbsmaya
Copy link

Chris to check both instances of the listings and confirm the sort order on both (list view e.g. https://test-apply.opentech.fund/apply/rounds/732/ and the sort order within a grouping on the detail view e.g. ordering within 'Accepted' status on https://test-apply.opentech.fund/apply/rounds/732/?submission=17).

Following this we will confirm with @fourthletter what the correct sort order should be and adjust one of the lists.

@chris-lawton
Copy link
Contributor

Hi @fourthletter

Following on from Maya's comment above I can confirm the:

  • list view default ordering is by last updated
  • grouping on the detail view has no default ordering applied

Would you like the grouping on the detail view to be ordered by last updated or do you have another preference?

@fourthletter
Copy link
Contributor

@chris-lawton "grouping on the detail view to be ordered by last updated" would be great. Thanks!

The use case is Person A uses the list view to facilitate a meeting and lead the discussion while Person B uses the detail view for note-taking. We do not need these views to be mirror images or exact replicas, but it difficult for Person B to write notes about what Person A is discussing when the order is completely different. Confusion occurs when several applications are being discussed.

@chris-lawton
Copy link
Contributor

Ready for internal testing on dev.
Example:
Ordering of items here (by last updated) - https://dev-apply.opentech.fund/apply/rounds/732/?status=dismissed&query= should now be reflected in the 'dismissed' column here https://dev-apply.opentech.fund/apply/rounds/732/?submission=3

@abigail-hampson
Copy link

Looks good, this can be deployed to test

@fourthletter
Copy link
Contributor

Features are functional during test. Thanks! 💥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement This is an improvement of an existing thing (not a new thing, which would be a feature).
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants