Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment editing: front end #1194

Closed
18 tasks done
gibbsmaya opened this issue May 7, 2019 · 3 comments · Fixed by #1226
Closed
18 tasks done

Comment editing: front end #1194

gibbsmaya opened this issue May 7, 2019 · 3 comments · Fixed by #1226
Assignees

Comments

@gibbsmaya
Copy link

gibbsmaya commented May 7, 2019

Front end task for #945

Acceptance criteria

  • Private comments in django app allow editing by the author of the comment
  • Reviewers and Staff comments in django app allow editing by the author of the comment
  • Internal comments in django app allow editing by the author of the comment
  • Public comments in django app allow editing by the author of the comment
  • Edit button visible on comment (styled as per edit button on submission detail page)
  • Inline editing of comment with 'submit' and 'cancel' button
  • Updated comment to display on edit submission
  • Last edited date to be displayed alongside post date
  • Comment sort order remains as it currently is (by original post date)

QA criteria
Dev:

  • checked feature meets acceptance criteria/conforms exactly to the specification.
  • provided good unit test coverage (if this is non-trivial behaviour).
  • checked all tests for the project pass with this feature enabled.
  • checked code conforms to the project coding standards.
  • had code reviewed by another developer and resolved any issues raised.
  • tested this feature as an end user of the website/app (Can I get to it? Is it useable? Can I break it? Does it work in an end-to-end context?)
  • checked that this feature works on the server/s I am deploying it to.

QA:

  • tested this feature as a front end user and it meets the acceptance criteria/conforms to the specification and design.
  • checked that the feature works on the server/s deployed to
@chris-lawton
Copy link
Contributor

This is now on dev and ready for testing.

Head to https://dev-apply.opentech.fund/apply/submissions/, pick a submission and you will be able to edit any comment that you have authored.

@abigail-hampson
Copy link

Looks good to me, ready to go to the test server

@todd-dembrey todd-dembrey added the Status: Needs testing Tickets that need testing/qa label May 15, 2019
@abigail-hampson
Copy link

abigail-hampson commented May 15, 2019

This can be tested on #945, with the frontend and backend together

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants