Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment editing: Backend #1193

Closed
13 tasks done
gibbsmaya opened this issue May 7, 2019 · 3 comments · Fixed by #1226
Closed
13 tasks done

Comment editing: Backend #1193

gibbsmaya opened this issue May 7, 2019 · 3 comments · Fixed by #1226
Assignees

Comments

@gibbsmaya
Copy link

gibbsmaya commented May 7, 2019

Backend task for #945: comment API backend extended to handle tracking last updated

  • Comment list API includes last edited date
  • Comment editing API includes last edited in response data on successful edit
  • Confirm comment editing API limited to author
  • QA criteria satisfied

QA criteria
Dev:

  • checked that this feature works across all agreed supported browsers and devices.
  • checked that this code meets the agreed accessibility level.
  • checked that this code meets the agreed browser performance levels.
  • checked that this code conforms to the project coding standards.
  • had code reviewed by another developer and resolved any issues raised.
  • tested this feature as an end user.
  • checked that the feature works on the server/s I am deploying it to.

QA:

  • tested this feature as a front end user and it meets the acceptance criteria/conforms to the specification and design.
  • checked that the feature works on the server/s deployed to
@gibbsmaya gibbsmaya added this to the Todd mini sprint milestone May 7, 2019
todd-dembrey pushed a commit that referenced this issue May 8, 2019
…iting-be

Make the comment editable through the API
@todd-dembrey
Copy link
Contributor

Testing:

You can access the API on the dev environment, you will need to be logged in:

List of comments for a submission: https://dev-apply.opentech.fund/apply/api/submissions/10/comments/ where 10 is the id of the submission with comments.
You can also use the form at the bottom of the page to create a new comment.

Editing comments:
https://dev-apply.opentech.fund/apply/api/comments/296/edit/ where 296 is the comment you wish to edit. You can only edit your own comments, and can only edit a content once. After you have edited the comment it should remain in the same position in the list view, but with the extra edited field data.

@abigail-hampson
Copy link

Good to be deployed to the test server

@abigail-hampson
Copy link

This can be tested on #945, with the frontend and backend together

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants