Skip to content

More publish messages and documentation #2357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

More publish messages and documentation #2357

wants to merge 9 commits into from

Conversation

t-b
Copy link
Collaborator

@t-b t-b commented Feb 25, 2025 •
edited
Loading

Close #2354
Close #2327

@t-b t-b self-assigned this Feb 25, 2025
@t-b t-b force-pushed the feature/2357-more-publish-messages-and-documentation branch from 8ceb3c4 to 1d8ba32 Compare February 26, 2025 19:45
@t-b t-b added the PatchLink label Feb 28, 2025
@t-b t-b force-pushed the feature/2357-more-publish-messages-and-documentation branch from 0d674dc to b8f663e Compare March 3, 2025 18:46
@t-b t-b force-pushed the feature/2357-more-publish-messages-and-documentation branch 3 times, most recently from 4762cc8 to 2f8fddd Compare March 25, 2025 17:08
@t-b t-b force-pushed the feature/2357-more-publish-messages-and-documentation branch from 2f8fddd to 2fabe52 Compare March 25, 2025 17:59
@t-b t-b removed their assignment Mar 28, 2025
@t-b t-b force-pushed the feature/2357-more-publish-messages-and-documentation branch from 2fabe52 to 2e41d30 Compare April 5, 2025 13:25
@t-b t-b force-pushed the feature/2357-more-publish-messages-and-documentation branch from 2e41d30 to 1a27f98 Compare April 13, 2025 11:46
@t-b t-b marked this pull request as ready for review April 13, 2025 11:47
@t-b
Copy link
Collaborator Author

t-b commented Apr 13, 2025

@ben-at-allen This now has the additional messages "amplifier:set value" for amplifier value changes from within MIES and "configuration:finished" when the configuration is finished. I also added some documentation for all the messages, see the function documentation for FFI_GetAvailableMessageFilters.

@t-b t-b force-pushed the feature/2357-more-publish-messages-and-documentation branch from 1a27f98 to 5c52efa Compare April 14, 2025 18:50
@ben-at-allen
Copy link

ben-at-allen commented Apr 15, 2025 •
edited
Loading

Thanks @t-b ! I'll pull this down to Rig 5 for my work on Wednesday and Thursday of this week. Does this also include the changes from the test pulse branch that was merged into main?

@t-b t-b assigned t-b and unassigned ben-at-allen Apr 22, 2025
t-b added 9 commits April 25, 2025 20:34
@t-b
AI_MapNameToFunctionConstant: Add it
b839436
@t-b
IVS_PUB_FILTER: Remove it
a5a579b 
Unused since ce6f656 (IVS_runInitAccessResisQC: Prefer analysis function PSQ_AccessResistance, 2022-05-02).
@t-b
FFI_GetAvailableMessageFilters: Add documentation
c37f9b2
@t-b
PUB_GetJSONTemplate: Handle empty device
95fb732
@t-b
Tests/UTF_Configuration.ipf: Prefer calling TestCaseEndCommon
d4f1700 
This does all our ususal checks. For the empty datafolder check we also
need to kill the setvarTest global in TCONF_Load.
@t-b
PUB_ConfigurationFinished: Add new message
5ce17e6 
This message is sent after the JSON configuration for a panel or notebook is
finished.
@t-b
MIES_Publish.ipf: Add AMPLIFIER_SET_VALUE
a172ccb
@t-b
Tests/CheckMessageFilters_IGNORE: Add INFO string
24ef1e9
@t-b
MIES_Publish.ipf: Add TESTPULSE_SET_VALUE_FILTER
afb0f25 
Send a message when changing a TP setting in the DAEphys panel.
@t-b t-b force-pushed the feature/2357-more-publish-messages-and-documentation branch from 5c52efa to afb0f25 Compare April 25, 2025 20:33
@t-b
Copy link
Collaborator Author

t-b commented Apr 25, 2025

@ben-at-allen I've added a new message "testpulse:set value" which is sent when a TP setting is changed, this also includes the Auto TP settings.

@t-b t-b assigned ben-at-allen and t-b and unassigned t-b and ben-at-allen Apr 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timjarsky timjarsky Awaiting requested review from timjarsky timjarsky is a code owner

@MichaelHuth MichaelHuth Awaiting requested review from MichaelHuth MichaelHuth is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@t-b t-b

Labels
PatchLink
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Send ZMQ message for configuration start/stop Send ZMQ pub message with changed MCC settings
2 participants
@t-b @ben-at-allen