Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Forwardport] fix: prevent inline-block issue in name form due to space and font-size #2

Closed
wants to merge 241 commits into from

Conversation

viktym
Copy link
Owner

@viktym viktym commented Jun 18, 2018

Original Pull Request

magento#16048

Description

Fixed Issues (if relevant)

  1. inline-block issue in name form magento/magento2#16047

Manual testing scenarios

  1. open a page where the name form is eg /customer/account/edit/
  2. compare the space between asterisk / required field indicator to other fields with the required field indicator

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

rganin and others added 30 commits May 4, 2018 09:10
…oduct

MC-110: Admin should be able to add default video for bundle product
MC-108: Admin should be able to add default video for grouped product
MC-207: Admin should be able to remove default video from downloadable product
MC-205: Admin should be able to remove default video from bundle product
MC-203: Admin should be able to remove default video from grouped product

- updated mftf test
…product with product name

MC-144: Guest customer should be able to advance search configurable product with product sku
MC-237: Guest customer should be able to advance search configurable product with product description
MC-240: Guest customer should be able to advance search configurable product with product short description

- added mftf tests
…product with product name

MC-252: Guest customer should be able to advance search downloadable product with product sku
MC-243: Guest customer should be able to advance search downloadable product with product description
MC-245: Guest customer should be able to advance search downloadable product with product short description
MC-246: Guest customer should be able to advance search downloadable product with product price

- added mftf tests
…how up in search and layered navigation if Elasticsearch is enabled
…how up in search and layered navigation if Elasticsearch is enabled
…product with product name

MC-252: Guest customer should be able to advance search downloadable product with product sku
MC-243: Guest customer should be able to advance search downloadable product with product description
MC-245: Guest customer should be able to advance search downloadable product with product short description
MC-246: Guest customer should be able to advance search downloadable product with product price

- updated mftf tests
…t with product name

MC-143: Guest customer should be able to advance search bundle product with product sku
MC-242: Guest customer should be able to advance search bundle product with product description
MC-250: Guest customer should be able to advance search bundle product with product short description
MC-251: Guest customer should be able to advance search bundle product with product price

- added mftf tests
…how up in search and layered navigation if Elasticsearch is enabled
…how up in search and layered navigation if Elasticsearch is enabled
Magento CICD and others added 19 commits June 14, 2018 14:02
[Team 3] Improving dev experience for Products  widget
 - merged latest code from mainline branch
[borg] MAGETWO-91608: SEO-friendly URL for category page not working
 - merged latest code from mainline branch
Accepted Public Pull Requests:
 - magento#16103: [Forwardport] fixed word typo (by @hitesh-wagento)
 - magento#16117: Captcha: Added unit test for CheckRegisterCheckoutObserver (by @rogyar)
 - magento#16121: [Forwardport] Improve retrieval of first array element (by @thomas-blackbird)
 - magento#16128: [Forwardport] Disabling sorting in glob and scandir functions for better performance (by @lfluvisotto)
 - magento#16036: [Forwardport] Fix issue magento#15832 (by @chirag-wagento)
 - magento#15975: [Forwardport] magento#15308 removed extraneous margin (by @chirag-wagento)
 - magento#15982: Fix Magento\Sales\Service\V1\ShipmentGetTest::testShipmentGet (by @slackerzz)
 - magento#15974: Fix magento/inventory#1339 issue - Fix \Magento\Sales\Service\V1\ShipmentCreateTest::testInvoke (by @slackerzz)
 - magento#16006: 1334: CreateOrderBackendTest rework to support MSI 'Reorder' button new behaviour. (by @nmalevanec)
 - magento#15685: Fulltext replacement with like condition (by @phoenix128)


Fixed GitHub Issues:
 - magento#15832: No button-primary__font-weight (reported by @DanielRuf) has been fixed in magento#16036 by @chirag-wagento in 2.3-develop branch
   Related commits:
     1. d7e77e6
     2. c4de267

 - magento#15308: extraneous margins on product list and product list items (reported by @DanielRuf) has been fixed in magento#15975 by @chirag-wagento in 2.3-develop branch
   Related commits:
     1. eee2e7c

 - magento#1350: Install Quits on install on Magento_Catalog (reported by @Zaylril) has been fixed in magento#15982 by @slackerzz in 2.3-develop branch
   Related commits:
     1. 9e5757d
     2. 1555b96
     3. 039e71c

 - magento#680: More settings for image storage (reported by @bubach) has been fixed in magento#16006 by @nmalevanec in 2.3-develop branch
   Related commits:
     1. 0501e17
     2. 731b58f
     3. 7c3d53f
     4. 0d06ad8

 - magento#1221: "Uncaught TypeError: Event.observe is not a function" In Version 0.74.0-beta6 (reported by @RisingRavi) has been fixed in magento#15685 by @phoenix128 in 2.3-develop branch
   Related commits:
     1. 7259c4b
…-pdp

[borg] MAGETWO-91595: Image doesn't load on frontend PDP if the product name contains double quote "
@viktym viktym force-pushed the 2.3-develop-PR-port-16048 branch 4 times, most recently from 2594130 to 455e52a Compare June 18, 2018 16:35
@viktym viktym force-pushed the 2.3-develop-PR-port-16048 branch from 455e52a to 9171dd3 Compare June 18, 2018 16:55
@viktym viktym closed this Jun 18, 2018
@viktym viktym deleted the 2.3-develop-PR-port-16048 branch June 18, 2018 16:56
viktym pushed a commit that referenced this pull request Jun 23, 2018
 - Merge Pull Request magento#15798 from chirag-wagento/magento2:2.3-develop-PR-port-15789
 - Merged commits:
   1. cd0a7b4
viktym pushed a commit that referenced this pull request Jun 23, 2018
Accepted Public Pull Requests:
 - magento#16135: Fix type hints and add undefined property in Webapi [2.3-develop] (by @mhauri)
 - magento#16170: 1163: CreateCreditMemoEntityTest rework to support MSI reservation mechanism. (by @nmalevanec)
 - magento#16153: 1190: CreateOrderBackendPartOneTest rework to support MSI reservation mechanism. (by @nmalevanec)
 - magento#16061: Change the favicon file to the newer Magento logo (by @DMMundle)
 - magento#16155: [Forwardport] chore: prefer woff and woff2 (by @DanielRuf)
 - magento#15777: [Forwardport] Fix negative basket total due to shipping tax residue (by @osrecio)
 - magento#15861: [Forwardport] ISSUE-14747 Newsletter subscription confirmation message does not dis� (by @rahul-kachhadiya)
 - magento#16097: [Forwardport] fix: prevent inline-block issue in name form due to space and font-size (by @DanielRuf)
 - magento#15798: [Forwardport] Removed unnecessary css. #2 (by @chirag-wagento)
 - magento#16038: [Forwardport] bugfix checkout page cart icon color (by @chirag-wagento)
 - magento#15759: [Forwardport] 2.3 develop pr port 15566 (by @vgelani)
 - magento#16137: FIX for apparently random API failures while using array types (by @phoenix128)


Fixed GitHub Issues:
 - magento#1163: Problem when change less file in magento. (reported by @zivendesign) has been fixed in magento#16170 by @nmalevanec in 2.3-develop branch
   Related commits:
     1. f53c620

 - magento#1190: installation error in  0.74.0-beta4 (reported by @sivajik34) has been fixed in magento#16153 by @nmalevanec in 2.3-develop branch
   Related commits:
     1. 2b8b9d5

 - magento#14747: Newsletter subscription confirmation message does not display after clicking link in email (reported by @tohann) has been fixed in magento#15861 by @rahul-kachhadiya in 2.3-develop branch
   Related commits:
     1. 75516bf

 - magento#16047: inline-block issue in name form (reported by @DanielRuf) has been fixed in magento#16097 by @DanielRuf in 2.3-develop branch
   Related commits:
     1. 204b4ac

 - magento#15565: Getting wrong frontend-controller, when using storecodes in urls (reported by @EliasKotlyar) has been fixed in magento#15759 by @vgelani in 2.3-develop branch
   Related commits:
     1. 61856f5
     2. 4c77dff
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.