Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1334: CreateOrderBackendTest rework to support MSI 'Reorder' button new behaviour. #16006

Merged
merged 4 commits into from
Jun 18, 2018

Conversation

nmalevanec
Copy link
Contributor

@nmalevanec nmalevanec commented Jun 11, 2018

Description

Add shipment step to CreateOrderBackendTest in order to support "Reorder" button new behaviour with enabled MSI magento/inventory#680

Standard magento behaviour - "Reorder" button hides immediately after place order, but with MSI "Reorder" button hides only after shipment created, as MSI introduces additional property for product as 'salable quantity'. And after order placement, 'salable quantity' decreasing, not quantity itself(more about reservation mechanism here). Quantity decreasing only after shipment creation. So, in order to pass CreateOrderBackendTest with MSI, additional step with shipment creation should be added into test before assertions.

Fixed Issues (if relevant)

  1. Fix Reorder Button functionality inventory#1162: Fix Reorder Button functionality

Manual testing scenarios

  1. None.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

enterprise part: magento-engcom/magento2ee#161

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Jun 11, 2018

CLA assistant check
All committers have signed the CLA.

@nmalevanec nmalevanec changed the title 1334: CreateOrderBackendTest rework to support MSI 'Reorder button' new behaviour. 1334: CreateOrderBackendTest rework to support MSI 'Reorder' button new behaviour. Jun 11, 2018
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.0 milestone Jun 12, 2018
@magento-engcom-team magento-engcom-team merged commit 0d06ad8 into magento:2.3-develop Jun 18, 2018
magento-engcom-team pushed a commit that referenced this pull request Jun 18, 2018
@magento-engcom-team
Copy link
Contributor

Hi @nmalevanec. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.3.0 release.

@nmalevanec nmalevanec deleted the 1334 branch August 21, 2018 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants