Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fulltext replacement with like condition #15685

Merged
merged 1 commit into from
Jun 18, 2018
Merged

Fulltext replacement with like condition #15685

merged 1 commit into from
Jun 18, 2018

Conversation

phoenix128
Copy link
Contributor

@phoenix128 phoenix128 commented Jun 2, 2018 •
edited
Loading

Fulltext replacement with like condition when a SearchCriteria is app…lied to a DB collection.
See magento/inventory#1221

Description

When a search criteria is run over a MySQL based entty, the condition is improperly translated with eq condition.
Translating with a like condition is much more similar to a fulltext.

See magento/inventory#1221
See magento/inventory#1285

Fixed Issues (if relevant)

  1. magento-engcom/msi/issues#1221: Issue title

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team magento-engcom-team added Partner: MageSpecialist partners-contribution Pull Request is created by Magento Partner labels Jun 2, 2018
@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Jun 2, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team magento-engcom-team added the Component: Framework/Api USE ONLY for FRAMEWORK RELATED BUG! E.g If bug related to Catalog Service Contracts use just Catalog label Jun 2, 2018
@dmanners dmanners added the mm18nl label Jun 2, 2018
@phoenix128 phoenix128 mentioned this pull request Jun 2, 2018
Merged
4 tasks
@okorshenko okorshenko removed the mm18nl label Jun 5, 2018
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.0 milestone Jun 7, 2018
@osrecio osrecio requested a review from naydav June 14, 2018 12:15
@VladimirZaets VladimirZaets mentioned this pull request Jun 18, 2018
Closed
@magento-engcom-team magento-engcom-team merged commit 7259c4b into magento:2.3-develop Jun 18, 2018
magento-engcom-team pushed a commit that referenced this pull request Jun 18, 2018
ENGCOM-1910: Fulltext replacement with like condition #15685
feb7a67
@magento-engcom-team
Copy link
Contributor

Hi @phoenix128. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.3.0 release.

@ronak2ram ronak2ram mentioned this pull request Jul 15, 2018
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@naydav naydav Awaiting requested review from naydav

Assignees

@ishakhsuvarov ishakhsuvarov

Labels
Component: Framework/Api USE ONLY for FRAMEWORK RELATED BUG! E.g If bug related to Catalog Service Contracts use just Catalog Partner: MageSpecialist partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.0
Development

Successfully merging this pull request may close these issues.
6 participants
@phoenix128 @magento-cicd2 @magento-engcom-team @dmanners @ishakhsuvarov @okorshenko