Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] Fulltext replacement with like condition #16827

Closed
wants to merge 1 commit into from
Closed

[Backport] Fulltext replacement with like condition #16827

wants to merge 1 commit into from

Conversation

ronak2ram
Copy link
Member

Original Pull Request

#15685
Fulltext replacement with like condition when a SearchCriteria is app…lied to a DB collection.
See magento/inventory#1221

Description

When a search criteria is run over a MySQL based entty, the condition is improperly translated with eq condition.
Translating with a like condition is much more similar to a fulltext.

See magento/inventory#1221
See magento/inventory#1285

Fixed Issues (if relevant)

  1. magento-engcom/msi/issues#1221: Issue title

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team magento-engcom-team added the Component: Framework/Api USE ONLY for FRAMEWORK RELATED BUG! E.g If bug related to Catalog Service Contracts use just Catalog label Jul 15, 2018
@magento-engcom-team
Copy link
Contributor

Hi @ronak2ram. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@sidolov sidolov self-assigned this Jul 15, 2018
@sidolov sidolov self-requested a review July 15, 2018 12:46
Copy link
Contributor

@sidolov sidolov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, cover changes with unit test

@sidolov
Copy link
Contributor

sidolov commented Jul 29, 2018

@ronak2ram , I am closing this PR now due to inactivity.
Please reopen and update if you wish to continue.
Thank you for the collaboration!

@sidolov sidolov closed this Jul 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Framework/Api USE ONLY for FRAMEWORK RELATED BUG! E.g If bug related to Catalog Service Contracts use just Catalog help wanted Progress: needs update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants