Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Magento\Sales\Service\V1\ShipmentGetTest::testShipmentGet #15982

Conversation

slackerzz
Copy link
Member

Description

Fixed Issues (if relevant)

  1. Fix Magento\Sales\Service\V1\ShipmentGetTest::testShipmentGet inventory#1336: Fix Magento\Sales\Service\V1\ShipmentGetTest::testShipmentGet
    Related msi pull request: magento-engcom#1350

Manual testing scenarios

  1. ...
  2. ...

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@slackerzz slackerzz force-pushed the fix_Magento.Sales.Service.V1.ShipmentGetTest.testShipmentGet branch from 22b46d3 to 9e5757d Compare June 10, 2018 10:28
@slackerzz
Copy link
Member Author

slackerzz commented Jun 11, 2018

@vgelani did you run the test after your commit?
Now it fails with:
Class Magento\Sales\Service\V1\Magento\Framework\Api\SimpleDataObjectConverter does not exist

I'm sorry but your commit introduces several errors:

  • when you have 2 nested foreach you cannot use the same variables names, it won't work
  • SimpleDataObjectConverter::snakeCaseToUpperCamelCase() is always used statically in the core
  • using $this->objectManager->get() inside the nested foreach loop is a bad practice

Moreover the pull request was correct before your commit and reviewed by @maghamed in the msi corresponding pull request.
For all these reasons I'll revert your changes.

@gelanivishal
Copy link
Contributor

gelanivishal commented Jun 11, 2018

@slackerzz I have performed these changes which gave errors in travis so I have performed it.

@magento-engcom-team
Copy link
Contributor

Hi @slackerzz. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.3.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants