Fix Magento\Sales\Service\V1\ShipmentGetTest::testShipmentGet #1350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slackerzz
force-pushed
the
fix_issue_1336
branch
from
fbfbede to
6821323
Compare
maghamed
suggested changes
Jun 10, 2018
| @@ -57,7 +58,14 @@ public function testShipmentGet() | |||
| unset($data['tracks']); | |||
| foreach ($data as $key => $value) { | |||
| if (!empty($value)) { | |||
| $this->assertEquals($shipment->getData($key), $value, $key); | |||
| if($key === 'extension_attributes') { | |||
There was a problem hiding this comment.
you should have space between if and (
| @@ -57,7 +58,14 @@ public function testShipmentGet() | |||
| unset($data['tracks']); | |||
| foreach ($data as $key => $value) { | |||
| if (!empty($value)) { | |||
| $this->assertEquals($shipment->getData($key), $value, $key); | |||
| if($key === 'extension_attributes') { | |||
There was a problem hiding this comment.
you should use constant ExtensibleDataInterface::EXTENSION_ATTRIBUTES_KEY
| @@ -57,7 +58,14 @@ public function testShipmentGet() | |||
| unset($data['tracks']); | |||
| foreach ($data as $key => $value) { | |||
| if (!empty($value)) { | |||
| $this->assertEquals($shipment->getData($key), $value, $key); | |||
| if($key === 'extension_attributes') { | |||
| foreach ($value as $k => $val) { | |||
There was a problem hiding this comment.
use more precise variable names instead of $k and $val
shortening is always bad practice
| $this->assertEquals($shipment->getExtensionAttributes()->$methodName(), $val); | ||
| } | ||
| } else { | ||
| $this->assertEquals($shipment->getData($key), $value, $key); |
There was a problem hiding this comment.
the same Pull Request should be created for https://github.com/magento/magento2 github
also, please provide cross-linkage between them
slackerzz
force-pushed
the
fix_issue_1336
branch
from
6821323 to
4ae69b3
Compare
|
@maghamed I've updated the pull request according your suggestions. Let me know if it's ok now and I'll create it in magento/magento2 |
This was referenced Jun 10, 2018
slackerzz
force-pushed
the
fix_issue_1336
branch
from
4ae69b3 to
b40a94e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed Issues (if relevant)
Related magento pull request: Fix Magento\Sales\Service\V1\ShipmentGetTest::testShipmentGet magento2#15982
Manual testing scenarios
Contribution checklist