Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Forwardport] fix: prevent inline-block issue in name form due to space and font-size #1

Closed
wants to merge 241 commits into from

Conversation

viktym
Copy link
Owner

@viktym viktym commented Jun 14, 2018

Original Pull Request

magento#16048

Description

Fixed Issues (if relevant)

  1. inline-block issue in name form magento/magento2#16047

Manual testing scenarios

  1. open a page where the name form is eg /customer/account/edit/
  2. compare the space between asterisk / required field indicator to other fields with the required field indicator

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

rganin and others added 30 commits May 4, 2018 09:10
…oduct

MC-110: Admin should be able to add default video for bundle product
MC-108: Admin should be able to add default video for grouped product
MC-207: Admin should be able to remove default video from downloadable product
MC-205: Admin should be able to remove default video from bundle product
MC-203: Admin should be able to remove default video from grouped product

- updated mftf test
…product with product name

MC-144: Guest customer should be able to advance search configurable product with product sku
MC-237: Guest customer should be able to advance search configurable product with product description
MC-240: Guest customer should be able to advance search configurable product with product short description

- added mftf tests
…product with product name

MC-252: Guest customer should be able to advance search downloadable product with product sku
MC-243: Guest customer should be able to advance search downloadable product with product description
MC-245: Guest customer should be able to advance search downloadable product with product short description
MC-246: Guest customer should be able to advance search downloadable product with product price

- added mftf tests
…how up in search and layered navigation if Elasticsearch is enabled
…how up in search and layered navigation if Elasticsearch is enabled
…product with product name

MC-252: Guest customer should be able to advance search downloadable product with product sku
MC-243: Guest customer should be able to advance search downloadable product with product description
MC-245: Guest customer should be able to advance search downloadable product with product short description
MC-246: Guest customer should be able to advance search downloadable product with product price

- updated mftf tests
…t with product name

MC-143: Guest customer should be able to advance search bundle product with product sku
MC-242: Guest customer should be able to advance search bundle product with product description
MC-250: Guest customer should be able to advance search bundle product with product short description
MC-251: Guest customer should be able to advance search bundle product with product price

- added mftf tests
…how up in search and layered navigation if Elasticsearch is enabled
…how up in search and layered navigation if Elasticsearch is enabled
nathanjosiah and others added 22 commits June 14, 2018 15:33
 - Merge Pull Request magento#16036 from chirag-wagento/magento2:2.3-develop-PR-port-16012
 - Merged commits:
   1. d7e77e6
   2. c4de267
…gento#15975

 - Merge Pull Request magento#15975 from chirag-wagento/magento2:2.3-develop-PR-port-15936
 - Merged commits:
   1. eee2e7c
[Team 3] Improving dev experience for Products  widget
 - merged latest code from mainline branch
[borg] MAGETWO-91608: SEO-friendly URL for category page not working
 - merged latest code from mainline branch
Accepted Public Pull Requests:
 - magento#16103: [Forwardport] fixed word typo (by @hitesh-wagento)
 - magento#16117: Captcha: Added unit test for CheckRegisterCheckoutObserver (by @rogyar)
 - magento#16121: [Forwardport] Improve retrieval of first array element (by @thomas-blackbird)
 - magento#16128: [Forwardport] Disabling sorting in glob and scandir functions for better performance (by @lfluvisotto)
 - magento#16036: [Forwardport] Fix issue magento#15832 (by @chirag-wagento)
 - magento#15975: [Forwardport] magento#15308 removed extraneous margin (by @chirag-wagento)
 - magento#15982: Fix Magento\Sales\Service\V1\ShipmentGetTest::testShipmentGet (by @slackerzz)
 - magento#15974: Fix magento/inventory#1339 issue - Fix \Magento\Sales\Service\V1\ShipmentCreateTest::testInvoke (by @slackerzz)
 - magento#16006: 1334: CreateOrderBackendTest rework to support MSI 'Reorder' button new behaviour. (by @nmalevanec)
 - magento#15685: Fulltext replacement with like condition (by @phoenix128)


Fixed GitHub Issues:
 - magento#15832: No button-primary__font-weight (reported by @DanielRuf) has been fixed in magento#16036 by @chirag-wagento in 2.3-develop branch
   Related commits:
     1. d7e77e6
     2. c4de267

 - magento#15308: extraneous margins on product list and product list items (reported by @DanielRuf) has been fixed in magento#15975 by @chirag-wagento in 2.3-develop branch
   Related commits:
     1. eee2e7c

 - magento#1350: Install Quits on install on Magento_Catalog (reported by @Zaylril) has been fixed in magento#15982 by @slackerzz in 2.3-develop branch
   Related commits:
     1. 9e5757d
     2. 1555b96
     3. 039e71c

 - magento#680: More settings for image storage (reported by @bubach) has been fixed in magento#16006 by @nmalevanec in 2.3-develop branch
   Related commits:
     1. 0501e17
     2. 731b58f
     3. 7c3d53f
     4. 0d06ad8

 - magento#1221: "Uncaught TypeError: Event.observe is not a function" In Version 0.74.0-beta6 (reported by @RisingRavi) has been fixed in magento#15685 by @phoenix128 in 2.3-develop branch
   Related commits:
     1. 7259c4b
…-pdp

[borg] MAGETWO-91595: Image doesn't load on frontend PDP if the product name contains double quote "
@viktym viktym force-pushed the 2.3-develop-PR-port-16048 branch 2 times, most recently from dbf2a90 to 85d287c Compare June 18, 2018 16:04
@viktym viktym force-pushed the 2.3-develop-PR-port-16048 branch from 85d287c to 2fc1287 Compare June 18, 2018 16:13
@viktym viktym closed this Jun 18, 2018
viktym pushed a commit that referenced this pull request Jun 23, 2018
…nto#15726

 - Merge Pull Request magento#15726 from sanjay-wagento/magento2:2.3-develop-PR-port-13026
 - Merged commits:
   1. ce176d2
viktym pushed a commit that referenced this pull request Jun 23, 2018
Accepted Public Pull Requests:
 - magento#16275: Simplified TypeProcessor (by @joni-jones)
 - magento#15842: [Forwardport] Add missing table aliases to fields mapping for Customer Group filter� (by @hitesh-wagento)
 - magento#15744: [Forwardport] [BUGFIX] magento#15564 Generated admin API token expires immediately (by @vijay-wagento)
 - magento#15726: Forwardport] Feature space between category page #1 (by @sanjay-wagento)
 - magento#15698: [Forwardport] Variant product image in sidebar wishlist block (by @dmytro-ch)
 - magento#15672: [FORWARDPORT magento#15097] Add field to filter to collection (by @dverkade)
 - magento#16256: magento#15255 unlock customer after password reset (by @vgelani)
 - magento#16246: [Forwardport] array_push(...) calls behaving as '$array[] = ...', $array[] = works faster than invoking functions in PHP (by @lfluvisotto)
 - magento#16224: [Forwardport] Correct return type of methods and typo correction. (by @saurabh-aureate)
 - magento#16225: Navigation dropdown caret icon. (by @tejash-wagento)
 - magento#15980: Use correct error message for duplicate error key in product import (by @denteblu)


Fixed GitHub Issues:
 - magento#15822: SQL Error: ambiguous column 'customer_group_id' in 'All customers' page in admin when extension attribute table is joined (reported by @radio) has been fixed in magento#15842 by @hitesh-wagento in 2.3-develop branch
   Related commits:
     1. 0f23ed7

 - magento#15564: 2.2.4 Created admin token has no access (reported by @krukas) has been fixed in magento#15744 by @vijay-wagento in 2.3-develop branch
   Related commits:
     1. 7f34b22
     2. 349d178

 - magento#12601: A space between the category page and the main footer when applying specific settings (reported by @wd7080) has been fixed in magento#15726 by @sanjay-wagento in 2.3-develop branch
   Related commits:
     1. ce176d2

 - magento#15255: Customer who exceeded max login failures not able to login even after reset password (reported by @tizzyguy87) has been fixed in magento#16256 by @vgelani in 2.3-develop branch
   Related commits:
     1. a108233
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.