Skips to ask specifications for optional workspace #1465

pratap0007 · 2021-10-19T16:07:24Z

Changes

This patch skips to ask specifications for optional workspace in an interactive mode if workspace of t/p/ct is optional and optional workspace skip flag(--skip-optional-workspace)is passed with tkn t/p/ct start command

Closes: #1444

Signed-off-by: Shiv Verma [email protected]

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

Includes tests (if functionality changed/added)
Run the code checkers with make check
Regenerate the manpages, docs and go formatting with make generated
Commit messages follow commit message best practices

See the contribution guide
for more details.

Release Notes

tekton-robot · 2021-10-19T16:11:01Z

The following is the coverage report on the affected files.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/cmd/pipeline/start.go	65.9%	65.8%	-0.2

piyush-garg · 2021-10-21T05:59:45Z

@pratap0007 Can you please add tests for this

tekton-robot · 2022-01-19T06:37:27Z

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale with a justification.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

tekton-robot · 2022-01-19T09:09:46Z

The following is the coverage report on the affected files.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/cmd/clustertask/start.go	80.1%	80.2%	0.1
pkg/cmd/pipeline/start.go	65.9%	65.7%	-0.2
pkg/cmd/task/start.go	80.9%	81.0%	0.1

vinamra28 · 2022-01-20T12:39:42Z

/remove-lifecycle stale

tekton-robot · 2022-01-24T09:03:06Z

The following is the coverage report on the affected files.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/cmd/clustertask/start.go	80.1%	80.2%	0.1
pkg/cmd/pipeline/start.go	65.9%	66.1%	0.2
pkg/cmd/task/start.go	80.9%	81.0%	0.1

vinamra28 · 2022-01-25T05:37:45Z

pkg/cmd/clustertask/start.go

@@ -195,6 +196,7 @@ For passing the workspaces via flags:
 	c.Flags().StringVarP(&opt.PrefixName, "prefix-name", "", "", "specify a prefix for the TaskRun name (must be lowercase alphanumeric characters)")
 	c.Flags().StringVar(&opt.PodTemplate, "pod-template", "", "local or remote file containing a PodTemplate definition")
 	c.Flags().BoolVar(&opt.UseParamDefaults, "use-param-defaults", false, "use default parameter values without prompting for input")
+	c.Flags().BoolVarP(&opt.SkipOptionalWorkspace, "skip-optional-workspace", "", false, "skip to ask specification for optional workspace")


how about adding the description -> skips the prompt for optional workspaces ?

vinamra28 · 2022-01-25T05:43:54Z

pkg/cmd/task/start_test.go

+func Test_start_task_with_skip_optional_workspace_flag(t *testing.T) {
+	tasks := []*v1alpha1.Task{
+		{
+			ObjectMeta: metav1.ObjectMeta{
+				Name:      "task-1",
+				Namespace: "ns",
+			},
+			Spec: v1alpha1.TaskSpec{
+				TaskSpec: v1beta1.TaskSpec{


instead of using v1alpha1 structs, can we use v1beta1 structs here?

vinamra28 · 2022-01-25T05:48:59Z

pkg/cmd/task/start.go

@@ -218,7 +219,7 @@ For passing the workspaces via flags:
 	c.Flags().StringVarP(&opt.PrefixName, "prefix-name", "", "", "specify a prefix for the TaskRun name (must be lowercase alphanumeric characters)")
 	c.Flags().BoolVarP(&opt.UseParamDefaults, "use-param-defaults", "", false, "use default parameter values without prompting for input")
 	c.Flags().StringVar(&opt.PodTemplate, "pod-template", "", "local or remote file containing a PodTemplate definition")
-
+	c.Flags().BoolVarP(&opt.SkipOptionalWorkspace, "skip-optional-workspace", "", false, "skip to ask specification for optional workspace")


same as previous

vinamra28 · 2022-01-25T05:50:34Z

pkg/cmd/pipeline/start.go

@@ -191,6 +192,7 @@ For passing the workspaces via flags:
 	c.Flags().StringVarP(&opt.Filename, "filename", "f", "", "local or remote file name containing a Pipeline definition to start a PipelineRun")
 	c.Flags().BoolVarP(&opt.UseParamDefaults, "use-param-defaults", "", false, "use default parameter values without prompting for input")
 	c.Flags().StringVar(&opt.PodTemplate, "pod-template", "", "local or remote file containing a PodTemplate definition")
+	c.Flags().BoolVarP(&opt.SkipOptionalWorkspace, "skip-optional-workspace", "", false, "skip to ask specification for optional workspace")


same as above

This patch skips to ask specifications for optional workspace in an intractie mode if workspace of t/p/ct is optional and optional workspace skip flag(--skip-optional-workspace) is passed with `tkn t/p/ct start` command Signed-off-by: Shiv Verma <[email protected]>

tekton-robot · 2022-01-25T10:32:31Z

The following is the coverage report on the affected files.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/cmd/clustertask/start.go	80.1%	80.2%	0.1
pkg/cmd/pipeline/start.go	65.9%	66.1%	0.2
pkg/cmd/task/start.go	80.9%	81.0%	0.1

vinamra28

/lgtm

tekton-robot · 2022-01-26T15:59:07Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Oct 19, 2021

tekton-robot requested review from danielhelfand and piyush-garg October 19, 2021 16:07

tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 19, 2021

tekton-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 19, 2022

pratap0007 force-pushed the optional-workspace branch from 0a34d20 to 9963427 Compare January 19, 2022 09:06

tekton-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 19, 2022

tekton-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 20, 2022

pratap0007 force-pushed the optional-workspace branch from 9963427 to a46a1bf Compare January 24, 2022 08:59

vinamra28 reviewed Jan 25, 2022

View reviewed changes

pratap0007 force-pushed the optional-workspace branch from a46a1bf to 5d385a9 Compare January 25, 2022 10:29

vinamra28 reviewed Jan 25, 2022

View reviewed changes

tekton-robot assigned vinamra28 Jan 25, 2022

tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 25, 2022

vdemeester approved these changes Jan 26, 2022

View reviewed changes

tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 26, 2022

tekton-robot merged commit ba8be48 into tektoncd:main Jan 26, 2022

This was referenced Jan 28, 2022

feat: add support for optional workspace redhat-developer/intellij-tekton#458

Merged

Handle optional workspaces redhat-developer/intellij-tekton#241

Closed

lstocchi mentioned this pull request Feb 7, 2022

Handle optional workspaces redhat-developer/vscode-tekton#667

Open

piyush-garg mentioned this pull request Feb 8, 2022

Add --use-workspace-defaults #1441

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Skips to ask specifications for optional workspace #1465

Skips to ask specifications for optional workspace #1465

pratap0007 commented Oct 19, 2021 •

edited

Loading

tekton-robot commented Oct 19, 2021

piyush-garg commented Oct 21, 2021

tekton-robot commented Jan 19, 2022

tekton-robot commented Jan 19, 2022

vinamra28 commented Jan 20, 2022

tekton-robot commented Jan 24, 2022

vinamra28 Jan 25, 2022

vinamra28 Jan 25, 2022

vinamra28 Jan 25, 2022

vinamra28 Jan 25, 2022

tekton-robot commented Jan 25, 2022

vinamra28 left a comment

tekton-robot commented Jan 26, 2022

Skips to ask specifications for optional workspace #1465

Skips to ask specifications for optional workspace #1465

Conversation

pratap0007 commented Oct 19, 2021 • edited Loading

Changes

Submitter Checklist

Release Notes

tekton-robot commented Oct 19, 2021

piyush-garg commented Oct 21, 2021

tekton-robot commented Jan 19, 2022

tekton-robot commented Jan 19, 2022

vinamra28 commented Jan 20, 2022

tekton-robot commented Jan 24, 2022

vinamra28 Jan 25, 2022

Choose a reason for hiding this comment

vinamra28 Jan 25, 2022

Choose a reason for hiding this comment

vinamra28 Jan 25, 2022

Choose a reason for hiding this comment

vinamra28 Jan 25, 2022

Choose a reason for hiding this comment

tekton-robot commented Jan 25, 2022

vinamra28 left a comment

Choose a reason for hiding this comment

tekton-robot commented Jan 26, 2022

pratap0007 commented Oct 19, 2021 •

edited

Loading