Add --use-workspace-defaults

[AeroNotix]

• tkn task start always asks for the configuration of the workspaces,
  even if you have:

  default-task-run-workspace-binding: |
    emptyDir: {}

In the config-defaults.

If there is another way to achieve this, please let me know.

Add a new flag `--use-workspace-default` to use the configured default workspace for the task run

[linux-foundation-easycla]

The committers are authorized under a signed CLA.

• ✅ Aaron France (0de0504)

[tekton-robot]

Hi @AeroNotix. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[AeroNotix]

/assign @danielhelfand

[chmouel]

if you set UseParamDefaults as false, it should use the workspace defaults? If this doesn't happen like this it would be a bug isnt it ?

(also if we go forward on this please consider adding a test)

/ok-to-test

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/cmd/task/start.go	80.9%	81.0%	0.1

[AeroNotix]

@chmouel no, using just --use-param-defaults=false without what I added, still prompts for the workspace configuration.

[AeroNotix]

/retest

[AeroNotix]

@danielhelfand can I get some help moving this along, please? What do I need to do/answer/change/discover/debug etc.

[AeroNotix]

The CI failure looks to be a documentantion related thing.. what do I need to fix?

[vinamra28]

The committers are authorized under a signed CLA.

• ✅ Aaron France (0de0504, be37447)

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/cmd/task/start.go	81.0%	81.1%	0.1

[piyush-garg]

@pradeepitm12 @vinamra28 @chmouel I think this we can close as #1465 is merged

[vinamra28]

@pradeepitm12 @vinamra28 @chmouel I think this we can close as #1465 is merged

@piyush-garg I think we can still consider this as this is solving a different problem. There is a field in configmap as config-defaults where we can set the value of key default-task-run-workspace-binding. If I am not wrong then this PR is to handle this scenario 😅
#1465 is just to handle the binding of optional workspaces. This PR is to handle all the workspaces. It's similar to --use-params-default flag

[piyush-garg]

@pradeepitm12 @vinamra28 @chmouel I think this we can close as #1465 is merged

@piyush-garg I think we can still consider this as this is solving a different problem. There is a field in configmap as config-defaults where we can set the value of key default-task-run-workspace-binding. If I am not wrong then this PR is to handle this scenario sweat_smile

Aah ok, this is for skipping all and #1465 is for skipping optional

[piyush-garg]

/retest

[AeroNotix]

Added the same flags for cluster/pipeline.

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/cmd/clustertask/start.go	80.2%	80.3%	0.1
pkg/cmd/pipeline/start.go	66.3%	66.4%	0.1
pkg/cmd/task/start.go	81.0%	81.1%	0.1

[vinamra28]

/retest

[AeroNotix]

@vinamra28 good to merge now?

[vdemeester]

Added a release-note block, it should be good to merge now
/cc @tektoncd/cli-maintainers

[piyush-garg]

Can we please add some tests for this?

[AeroNotix]

Can you point me to an existing test which tests similar functionality?

[tekton-robot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale with a justification.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

[tekton-robot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle rotten

Send feedback to tektoncd/plumbing.

[tekton-robot]

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen with a justification.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/close

Send feedback to tektoncd/plumbing.

[tekton-robot]

@tekton-robot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen with a justification.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/close

Send feedback to tektoncd/plumbing.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[piyush-garg]

/remove-lifecycle rotten

[piyush-garg]

Can you point me to an existing test which tests similar functionality?

you can take look at the tests fo --use-param-defaults to get an idea

[tekton-robot]

@AeroNotix: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-tekton-cli-integration-tests	62043f3	link	true	/test pull-tekton-cli-integration-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[AeroNotix]

I literally don't care.

[AeroNotix]

Over a year to get something so trivial in, I love the project but this is just unreal.