Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start pipeline/task with empty optional workspace without answering for specifications questions #1444

Closed
lstocchi opened this issue Sep 3, 2021 · 5 comments · Fixed by #1465
Assignees
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.
Milestone

Comments

@lstocchi
Copy link

lstocchi commented Sep 3, 2021

Feature request

If you try to start a pipeline which has an optional workspace and this is voluntarily left blank the user is still asked Do you want to give specifications for the optional workspace?. Is there a way to bypass/prevent it?

Use case

We are adding support for optional workspaces in our IDE tekton plugins. Users fill in the wizard with all params/workspaces to start the pipeline/task. If a workspace is optional and it's left empty, i shouldn't ask users if they are sure of their choice.

@lstocchi lstocchi added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 3, 2021
@piyush-garg
Copy link
Contributor

Yup, this makes sense. If the workspace is optional, we should not ask for values in interactive flow.

cc @vdemeester @pradeepitm12

@piyush-garg piyush-garg added the good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. label Oct 8, 2021
@pratap0007
Copy link
Contributor

/assign

@pratap0007
Copy link
Contributor

pratap0007 commented Oct 27, 2021

Hi @lstocchi, Could you please explain the issue and your use case a bit more, from the above issue what I understand is that if workspace is optional then specification for workspace shouldn't ask, is this correct?

@piyush-garg piyush-garg added this to the 0.22.0 milestone Nov 24, 2021
@lstocchi
Copy link
Author

lstocchi commented Dec 1, 2021

Hi @pratap0007 and sorry for the late response, i completely miss the notification.
Yes, what we need is a way to run the start command through the cli without specifying a workspace (if optional).

Something like ... if the task has 3 inputs (2 params and 1 optional workspace) i would like to run tkn pipeline start -p .. -p ... without that the cli asks me if i'm sure about it. Or having some other way to achieve it (a flag ... tkn pipeline start -p .. -p ... --skip-optional. or whatever)

In IntelliJ/vscode we show a wizard to allow user select workspaces and other inputs required to start a task/pipeline, but, if a workspace is optional, user is free to not pick anything and click on start. If this happens, I should be able to run the start command in the cli without setting that optional workspace and without the cli asks me for confirmation.

Let me know if it's clear. Thank you!!

@pratap0007
Copy link
Contributor

@lstocchi yes, it's clear now and thank you for clarifying it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants