Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for optional workspace #458

Merged
merged 3 commits into from
Feb 9, 2022

Conversation

lstocchi
Copy link
Contributor

@lstocchi lstocchi commented Sep 2, 2021

it resolves #241

@lstocchi
Copy link
Contributor Author

lstocchi commented Sep 3, 2021

Blocked for the moment, asked if there is a way to bypass questions about empty optional workspaces tektoncd/cli#1444

@lstocchi
Copy link
Contributor Author

tektoncd/cli#1465 has been merged. We can work on it again 🤞

Signed-off-by: Luca Stocchi <[email protected]>
@lstocchi lstocchi marked this pull request as ready for review February 8, 2022 11:54
@lstocchi
Copy link
Contributor Author

lstocchi commented Feb 8, 2022

@jeffmaury this patch allows users to start a pipeline/task with an optional workspace. So if a workspace is optional you are not forced to pick it and you can start the pipeline/task normally. If the workspace is not optional it works as before.

@lstocchi lstocchi requested a review from jeffmaury February 8, 2022 11:56
Copy link
Member

@jeffmaury jeffmaury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lstocchi lstocchi merged commit dd383bf into redhat-developer:main Feb 9, 2022
@lstocchi lstocchi deleted the i241 branch February 9, 2022 11:09
@lstocchi lstocchi added this to the 1.0.1 milestone Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle optional workspaces
2 participants