Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use wget Instead Of curl In Linux Installation Instructions #2238

Closed
wants to merge 13 commits into from
Closed

Use wget Instead Of curl In Linux Installation Instructions #2238

wants to merge 13 commits into from

Conversation

luxpir
Copy link

@luxpir luxpir commented Apr 10, 2018 •
edited
Loading

First time contributor checklist:

Contributor checklist:

Description

This PR references #2184 - unfortunately the site isn't hosted here, so PR may not be accepted? But the following:

curl -s https://updates.signal.org/desktop/apt/keys.asc | sudo apt-key add -
echo "deb [arch=amd64] https://updates.signal.org/desktop/apt xenial main" | sudo tee -a /etc/apt/sources.list.d/signal-xenial.list
sudo apt update && sudo apt install signal-desktop

Should be:

wget https://updates.signal.org/desktop/apt/keys.asc | sudo apt-key add -
echo "deb [arch=amd64] https://updates.signal.org/desktop/apt xenial main" | sudo tee -a /etc/apt/sources.list.d/signal-xenial.list
sudo apt update && sudo apt install apt-transport-https && sudo apt install signal-desktop

wget vs curl is debatable, but you definitely need apt-transport-https on a Debian-based distro to complete the install. This text to be amended is shown here and here.

scottnonnenberg-signal and others added 5 commits March 13, 2018 14:47
@scottnonnenberg-signal
Merge tag 'v1.6.0-beta.2'
20f31af 
v1.6.0-beta.2

Upgrade to the latest version of Electron, 1.8.2 (#2066)

Replace custom notification sound with system sound (#2108)

Update menus (#2078 and #2099)
  - A few copy changes to make things clearer
  - Settings now available via the File (Windows/Linux) or Signal
    Desktop (macOS) OS menu
  - Eliminate the triple-dot menu in the top-center of the screen

Fix: Hitting enter after entering device name on install would not move
to next screen (#2085)

Dev:
  - Ensure consistent builds using `yarn --frozen-lockfile` (#2098)
  - Update code to match eslint-enforced formatting (#2077)
  - Upgrade to latest version of electron-builder and associated
    packages (#2066 and #2097)
@scottnonnenberg-signal
v1.6.0
63c8e2f 
_Note: This release is equivalent to v1.6.0-beta.2
(https://github.com/signalapp/Signal-Desktop/releases/tag/v1.6.0-beta.2)_

Upgrade to the latest version of Electron, 1.8.2 (#2066)

Replace custom notification sound with system sound (#2108)

Update menus (#2078 and #2099)
  - A few copy changes to make things clearer
  - Settings now available via the File (Windows/Linux) or Signal Desktop
    (macOS) OS menu
  - Eliminate the triple-dot menu in the top-center of the screen

Fixed: Hitting enter after entering device name on install would not
move to next screen (#2085)

Dev:
  - Ensure consistent builds using yarn --frozen-lockfile (#2098)
  - Update code to match eslint-enforced formatting (#2077)
  - Upgrade to latest version of electron-builder and associated
    packages (#2066 and #2097)
@gasi-signal
Move Debug Logs From GitHub Gists to debuglogs.org (#2112)
f9603db 
In anticipation of GitHub’s deprecation of anonymous gists, we are moving our
debug logs to https://debuglogs.org.

- [x] Publish debug logs to debuglogs.org.
- [x] Rename **Help > File a Bug** to **Report an Issue** for consistency with
      our debug log view as well as other apps such as Google Chrome.
- [x] Quickfix: Ensure `window.isFocused` always returns a boolean.

**Sample log:** https://debuglogs.org/0272bdd35288ed839ede88938a5290011150d42b56599efb5dd93ac80a2ac915

---

Merge commit 'b2a252aa' into hotfix/1.6.1
@scottnonnenberg-signal
Merge branch 'hotfix/1.6.1' to move to debuglogs.org for logs
fad7b70
@scottnonnenberg-signal
v1.6.1
3a9696e 
Switch to a new service for debug logs, since GitHub is retiring
anonymous gists (#2112)
@gasi-signal
Copy link
Contributor

gasi-signal commented Apr 11, 2018 •
edited
Loading

@luxpir Thanks for the PR. Just to confirm, there are no actual changes in this project (noticing no commits from you) but rather the suggestion to change the install instructions for Linux in your description. I tested your script and it failed with this error in the first line:

gpg: no valid OpenPGP data found.

I had to add --quiet --output-document - options to wget:

wget --quiet --output-document - https://updates.signal.org/desktop/apt/keys.asc | sudo apt-key add -
echo "deb [arch=amd64] https://updates.signal.org/desktop/apt xenial main" | sudo tee -a /etc/apt/sources.list.d/signal-xenial.list
sudo apt update && sudo apt install apt-transport-https && sudo apt install signal-desktop

Can you please try this and confirm?

@scottnonnenberg-signal
Merge tag 'v1.7.0-beta.3'
f8bbdc6 
v1.7.0-beta.3

Update to electron 1.8.4 (#2186)

Migrate all attachments from IndexedDB to file system in the background (#2208, #2193, #2165, #2162, #2129)

Save attachments to disk when importing Chrome app export (#2212)

Fixed: Read receipts setting would not be synchronized along with re-link (#2218)

Fixed: Clicking conversation in left pane when already selected would remove focus on message composition field - thanks
@colefranz! (#2032)

Fixed: Searching for the phone number of an existing contact, then selecting 'start conversation' would erase contact details (#2191)

Fixed: Selecting Settings menu option multiple times would open multiple instances of settings view - thanks @navdeepsinghkhalsa (#2167)

Dev:
  - Relax Node.js version requirements (#2203)
  - Fix a few typos in documentation - thanks @Vinnl (#2171)
  - Update issue template to mention that translation should be via Transifex (#2157)
@scottnonnenberg-signal
v1.7.0
699acc6 
Note: this release is equivalent to v1.7.0-beta.3. The changes listed below are compared to the previous production release, v1.6.1.

Update to electron 1.8.4 (#2186)

Migrate all attachments from IndexedDB to file system in the background (#2208, #2193, #2165, #2162, #2129)
Save attachments to disk when importing Chrome app export (#2212)

New option in settings: delete all application data (383e02e, #2144 and #2153)

Remove all configuration in database when we discover we are unlinked (9acb189 and 1c6d91b)

Delete everything in database when we link with a different phone number from previous link (9acb189)

Windows: Delete all data on uninstall (c855597)

Fixed: Read receipts setting would not be synchronized along with re-link (#2218)

Fixed: Clicking conversation in left pane when already selected would remove focus on message composition field - thanks @colefranz! (#2032)

Fixed: Searching for the phone number of an existing contact, then selecting 'start conversation' would erase contact details (#2191)

Fixed: Selecting Settings menu option multiple times would open multiple instances of settings view - thanks @navdeepsinghkhalsa (#2167)

Dev:
  - Redact file paths in anything that goes to the log on disk (#2110)
  - When top-level process errors happen, don't show dialog with stack trace (#2110)
  - Add `nsp` to CI runs (fd056e1)
  - Add eslint-plugin-mocha to disallow exclusive tests using *.only (#2110)
  - Preparation for encrypted backups (cea42bd)
  - Updates to structure of exported data - messages.zip, flat list of attachments (6d8f4b7)
  - Relax Node.js version requirements (#2203)
  - Fix a few typos in documentation - thanks @Vinnl (#2171)
  - Update issue template to mention that translation should be via Transifex (#2157)
@gasi-signal gasi-signal changed the title Master Use wget Instead Of curl In Linux Installation Instructions Apr 11, 2018
@gasi-signal gasi-signal mentioned this pull request Apr 11, 2018
Closed
@scottnonnenberg-signal
Pull latest development for 1.7.1
847787f
@scottnonnenberg-signal
v1.7.1
c42c9cb 
Fixed: Conversation message preview would sometimes continue to show after message disappeared (1206b3c)

Improve URL Auto-Linking In Messages (#2240)

Redact More Variants Of Paths In Stack Traces (#2229)

Dev: Introduce React, TypeScript, TSLint and React-StyleGuidist (#2219 and #2232)
@jkterry1
Copy link

This works. please merge.

@scottnonnenberg-signal
Copy link
Contributor

@justinkterry This PR is broken for a number of reasons. Please don't comment here unless you have something productive to add to the conversation.

@scottnonnenberg-signal
Merging latest 1.8.0 beta changes to production
c0412ec
@scottnonnenberg-signal
v1.8.0
20b6842 
Support for receiving quoted replies (#2244, #2273, #2282)

iOS theme: one bubble for both attachment and message contents (#2244, #2273)

Dev: Fix beta install instructions in readme for debian-based linux (#2262)
@scottnonnenberg-signal
Merge tag 'v1.9.0-beta.1'
28eabd9 
v1.9.0-beta.1

Send quoted replies via hover menu on message (#2284, #2292)

Fixed: Linking a new iOS device would not initially show iOS theme (#2284)

Fixed: In iOS theme, narrow images would result in a broken chat bubble (#2273, #2282)

Dev:
  - Fix beta install instructions in readme for debian-based linux (#2262)
  - Media Gallery: Phase 1 - currently disabled (#2236)
@scottnonnenberg-signal
v1.9.0
da9f95d 
Send quoted replies via hover menu on message (#2284, #2292)

Fixed: Linking a new iOS device would not initially show iOS theme (#2284)

Dev: Media Gallery: Phase 1 - currently disabled (#2236)
@gasi-signal
Copy link
Contributor

Closing this PR as the code in question doesn’t live in this repository.

@gasi-signal gasi-signal closed this May 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@luxpir @gasi-signal @jkterry1 @scottnonnenberg-signal